Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29340595: Issue 3957 - Update dependency on adblockpluscore to revision 82c88024773b (Closed)

Created:
April 19, 2016, 3:38 p.m. by Wladimir Palant
Modified:
June 2, 2016, 6:39 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3957 - Update dependency on adblockpluscore to revision 82c88024773b Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/content/ui/filters-subscriptionview.js View 1 chunk +1 line, -0 lines 0 comments Download
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M metadata.gecko View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
April 19, 2016, 3:38 p.m. (2016-04-19 15:38:43 UTC) #1
Sebastian Noack
April 19, 2016, 3:54 p.m. (2016-04-19 15:54:44 UTC) #2
LGTM.

But please don't forget to file follow up issues, to be addressed after the
release, to reuse the EventEmitter for the messaging Port, as well to eventually
migrate to the new FilterNotifier API.

Powered by Google App Engine
This is Rietveld