Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164)

Issue 29340694: Issue 3956 - Convert domain whitelisting filters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by kzar
Modified:
3 years, 4 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3956 - Convert domain whitelisting filters

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed feedback #

Total comments: 2

Patch Set 3 : Avoid creating so many temporary arrays #

Total comments: 4

Patch Set 4 : Fix whitelisting request type logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -70 lines) Patch
M lib/abp2blocklist.js View 1 2 3 11 chunks +94 lines, -70 lines 0 comments Download

Messages

Total messages: 8
kzar
Patch Set 1 For EasyList this patchset results in the addition of a 8 new ...
3 years, 5 months ago (2016-04-20 17:16:42 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29340694/diff/29340695/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29340694/diff/29340695/lib/abp2blocklist.js#newcode227 lib/abp2blocklist.js:227: if (filter.contentType == typeMap.DOCUMENT && parsed.justHostname) For filters like ...
3 years, 4 months ago (2016-05-12 12:12:26 UTC) #2
kzar
Patch Set 2 : Addressed feedback https://codereview.adblockplus.org/29340694/diff/29340695/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29340694/diff/29340695/lib/abp2blocklist.js#newcode227 lib/abp2blocklist.js:227: if (filter.contentType == ...
3 years, 4 months ago (2016-05-16 16:22:36 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29340694/diff/29341424/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29340694/diff/29341424/lib/abp2blocklist.js#newcode463 lib/abp2blocklist.js:463: addRules([{ We are creating quite a few temporary arrays ...
3 years, 4 months ago (2016-05-17 10:17:54 UTC) #4
kzar
Patch Set 3 : Avoid creating so many temporay arrays https://codereview.adblockplus.org/29340694/diff/29341424/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29340694/diff/29341424/lib/abp2blocklist.js#newcode463 ...
3 years, 4 months ago (2016-05-17 10:38:02 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29340694/diff/29341470/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29340694/diff/29341470/lib/abp2blocklist.js#newcode240 lib/abp2blocklist.js:240: if (filter.contentType == typeMap.DOCUMENT) What if the filter is ...
3 years, 4 months ago (2016-05-17 10:55:25 UTC) #6
kzar
Patch Set 4 : Fix whitelisting request type logic https://codereview.adblockplus.org/29340694/diff/29341470/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29340694/diff/29341470/lib/abp2blocklist.js#newcode240 lib/abp2blocklist.js:240: ...
3 years, 4 months ago (2016-05-17 11:23:35 UTC) #7
Sebastian Noack
3 years, 4 months ago (2016-05-17 11:26:04 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5