Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127)

Issue 29340697: Issue 3962 - Update developer tools module paths in Element Hiding Helper (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Wladimir Palant
Modified:
3 years, 10 months ago
Reviewers:
saroyanm
Visibility:
Public.

Description

Issue 3962 - Update developer tools module paths in Element Hiding Helper Repository: hg.adblockplus.org/elemhidehelper

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M chrome/content/processScript.js View 1 chunk +23 lines, -2 lines 2 comments Download
M lib/inspectorObserver.js View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 10 months ago (2016-04-20 17:53:40 UTC) #1
saroyanm
https://codereview.adblockplus.org/29340697/diff/29340698/chrome/content/processScript.js File chrome/content/processScript.js (right): https://codereview.adblockplus.org/29340697/diff/29340698/chrome/content/processScript.js#newcode16 chrome/content/processScript.js:16: catch (e) According to our requirements page we are ...
3 years, 10 months ago (2016-04-21 12:24:13 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29340697/diff/29340698/chrome/content/processScript.js File chrome/content/processScript.js (right): https://codereview.adblockplus.org/29340697/diff/29340698/chrome/content/processScript.js#newcode16 chrome/content/processScript.js:16: catch (e) On 2016/04/21 12:24:13, saroyanm wrote: > According ...
3 years, 10 months ago (2016-04-21 13:05:16 UTC) #3
saroyanm
3 years, 10 months ago (2016-04-21 13:50:15 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5