Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: flake8-abp/tests/A203.py
Issue
29340727
:
Noissue - Added flake8 extension accounting for our coding style and some other stuff (Closed)
Patch Set: Added more checks, tests, README and addressed comments
Created May 7, 2016, 5:13 p.m.
Left:
Base
Patch Set 1:
Patch Set 2: Added more checks
Patch Set 3: Added check for redundant paranthesis
Patch Set 4: Accounf for elif
Patch Set 5: Added more checks, tests, README and addressed comments
Patch Set 6: Added README
Patch Set 7: Addressed comments, fixed two bugs, use ascii()
Right:
Patch Set 1:
Patch Set 2: Added more checks
Patch Set 3: Added check for redundant paranthesis
Patch Set 4: Accounf for elif
Patch Set 5: Added more checks, tests, README and addressed comments
Patch Set 6: Added README
Patch Set 7: Addressed comments, fixed two bugs, use ascii()
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.hgignore
flake8-abp/flake8_abp.py
flake8-abp/setup.py
flake8-abp/tests/A101.py
flake8-abp/tests/A102.py
flake8-abp/tests/A103.py
flake8-abp/tests/A104.py
flake8-abp/tests/A105.py
flake8-abp/tests/A106.py
flake8-abp/tests/A107.py
flake8-abp/tests/A108.py
flake8-abp/tests/A109.py
flake8-abp/tests/A110.py
flake8-abp/tests/A111.py
flake8-abp/tests/A201.py
flake8-abp/tests/A202.py
flake8-abp/tests/A203.py
flake8-abp/tests/A204.py
flake8-abp/tests/A204_module.py
flake8-abp/tests/A205.py
flake8-abp/tests/A206.py
flake8-abp/tests/A207.py
flake8-abp/tests/A301.py
flake8-abp/tests/A302.py
flake8-abp/tests/A303.py
flake8-abp/tox.ini
View unified diff
|
Download patch
« flake8-abp/setup.py
('K') |
« flake8-abp/tests/A202.py
('k') |
flake8-abp/tests/A204.py »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
def noop():
2
pass
3
4
5
def foo():
6
"""This is a doc string"""
7
# A203
8
'this string is unused'
9
noop()
10
11
12
def bar():
13
# A203
14
42
15
# A203
16
noop() is None
OLD
NEW
« flake8-abp/setup.py
('K') |
« flake8-abp/tests/A202.py
('k') |
flake8-abp/tests/A204.py »
('j') |
no next file with comments »
Edit Message
Issue 29340727: Noissue - Added flake8 extension accounting for our coding style and some other stuff (Closed)
Created April 21, 2016, 6:51 p.m. by Sebastian Noack
Modified May 17, 2016, 11:01 a.m.
Reviewers: Vasily Kuznetsov
Base URL:
Comments: 58
This is Rietveld