flake8-abp/tests/A111.py - Issue 29340727: Noissue - Added flake8 extension accounting for our coding style and some other stuff

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: flake8-abp/tests/A111.py

Issue 29340727: Noissue - Added flake8 extension accounting for our coding style and some other stuff (Closed)

Patch Set: Added README Created May 9, 2016, 1:43 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 def redundant_parenthesis(x, y, z):

	2 # * A111

	3 while (x):

	4 # * A111

	5 if ((x or y) and z):

	6 pass

	7 # * A111

	8 elif (x == max(y, z)):

	9 pass

	10 else:

	11 return

	12

	13

	14 def mandatory_parenthesis(x, y, z):

	15 if ():

	16 return

	17 if (x, y, z):

	18 return

	19

	20 if (x or y) and z:

	21 return

	22 if x and (y or z):

	23 return

	24

	25 if (x or

	26 y):

	27 return

OLD	NEW