Delta Between Two Patch Sets: flake8-abp/tests/A103.py
Issue 29340727:
Noissue - Added flake8 extension accounting for our coding style and some other stuff (Closed)
Left Patch Set: Added more checks
Created April 22, 2016, 12:02 p.m.
Right Patch Set: Addressed comments, fixed two bugs, use ascii()
Created May 9, 2016, 4:47 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« flake8-abp/tests/A102.py ('k')
|
flake8-abp/tests/A104.py » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| (no file at all) | |
| 1 def compare_int_like_yoda(x): | |
| 2 # * A103 | |
| 3 return 1 == x | |
| 4 | |
| 5 | |
| 6 def compare_string_like_yoda(x): | |
| 7 # * A103 | |
| 8 return 'foo' == x | |
| 9 | |
| 10 | |
| 11 def compare_none_like_yoda(x): | |
| 12 # * A103 | |
| 13 return None is x | |
| 14 | |
| 15 | |
| 16 def compare_tuple_like_yoda(x): | |
| 17 # * A103 | |
| 18 return (1, 'foo') == x | |
| 19 | |
| 20 | |
| 21 def compare_literals(): | |
| 22 return (1, 'foo') == (2, 'bar') | |
| 23 | |
| 24 | |
| 25 def compare_variables(a, b, c, d): | |
| 26 return (a, b) == (c, d) or a == b | |
| LEFT | RIGHT |
« flake8-abp/tests/A102.py ('k')
|
flake8-abp/tests/A104.py » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
