Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: flake8-abp/tests/A105.py

Issue 29340727: Noissue - Added flake8 extension accounting for our coding style and some other stuff (Closed)
Left Patch Set: Added check for redundant paranthesis Created April 22, 2016, 2:22 p.m.
Right Patch Set: Addressed comments, fixed two bugs, use ascii() Created May 9, 2016, 4:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « flake8-abp/tests/A104.py ('k') | flake8-abp/tests/A106.py » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 # A105
2 list([1])
3 # A105
4 list((1,))
5 # A105
6 tuple([1])
7 # A105
8 tuple((1,))
9 # A105
10 set([1])
11 # A105
12 set((1,))
13 # A105
14 dict([])
15 # A105
16 dict([[1, 1]])
17 # A105
18 dict([(1, 1)])
19 # A105
20 dict(())
21 # A105
22 dict(((1, 1),))
23 # A105
24 dict(([1, 1],))
25
26 # A105
27 list([x for x in range(10)])
28 # A105
29 list(x for x in range(10))
30 # A105
31 set([x for x in range(10)])
32 # A105
33 set(x for x in range(10))
34 # A105
35 dict([(x, x) for x in range(10)])
36 # A105
37 dict([[x, x] for x in range(10)])
38 # A105
39 dict((x, x) for x in range(10))
40 # A105
41 dict([x, x] for x in range(10))
42
43
44 def make_dict(x):
45 dict(x)
46 dict([x])
47 dict((x,))
48 dict([pair for pair in x])
49 dict(pair for pair in x)
50
51
52 def make_unique(x):
53 tuple({y for y in x})
54 list({y for y in x})
55
56
57 tuple([x for x in range(10)])
58 tuple(x for x in range(10))
59 tuple({x for x in range(10)})
LEFTRIGHT

Powered by Google App Engine
This is Rietveld