Delta Between Two Patch Sets: flake8-abp/tests/A111.py
Issue 29340727:
Noissue - Added flake8 extension accounting for our coding style and some other stuff (Closed)
Left Patch Set: Added check for redundant paranthesis
Created April 22, 2016, 2:22 p.m.
Right Patch Set: Addressed comments, fixed two bugs, use ascii()
Created May 9, 2016, 4:47 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« flake8-abp/tests/A110.py ('k')
|
flake8-abp/tests/A201.py » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| (no file at all) | |
| 1 def redundant_parenthesis(x, y, z): | |
| 2 # * A111 | |
| 3 while (x): | |
| 4 # * A111 | |
| 5 if ((x or y) and z): | |
| 6 pass | |
| 7 # * A111 | |
| 8 elif (x == max(y, z)): | |
| 9 pass | |
| 10 else: | |
| 11 return | |
| 12 | |
| 13 | |
| 14 def mandatory_parenthesis(x, y, z): | |
| 15 if (): | |
| 16 return | |
| 17 if (x, y, z): | |
| 18 return | |
| 19 | |
| 20 if (x or y) and z: | |
| 21 return | |
| 22 if x and (y or z): | |
| 23 return | |
| 24 | |
| 25 if (x or | |
| 26 y): | |
| 27 return | |
| LEFT | RIGHT |
« flake8-abp/tests/A110.py ('k')
|
flake8-abp/tests/A201.py » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
