Delta Between Two Patch Sets: flake8-abp/README.md
Issue 29340727:
Noissue - Added flake8 extension accounting for our coding style and some other stuff (Closed)
Left Patch Set: Added README
Created May 9, 2016, 1:43 p.m.
Right Patch Set: Addressed comments, fixed two bugs, use ascii()
Created May 9, 2016, 4:47 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« .hgignore ('k')
|
flake8-abp/flake8_abp.py » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 # flake8-abp | 1 # flake8-abp |
| 2 | 2 |
| 3 A [flake8](https://flake8.readthedocs.io) extension that checks for compliance | 3 A [flake8](https://flake8.readthedocs.io) extension that checks for compliance |
| 4 with the [Adblock Plus coding style guide](https://adblockplus.org/coding-style# python) | 4 with the [Adblock Plus coding style guide](https://adblockplus.org/coding-style# python) |
| 5 and some bad practices which flake8 doesn't handle by default. | 5 and some bad practices which flake8 doesn't handle by default. |
| 6 | 6 |
| 7 | 7 |
| 8 ## Installation | 8 ## Installation |
| 9 | 9 |
| 10 Run `python setup.py install`. | 10 Run `python setup.py install`. |
| (...skipping 22 matching lines...) Expand all Loading... | |
| 33 * `A109`: Use triple double quotes for docstrings as recommended in PEP-257 | 33 * `A109`: Use triple double quotes for docstrings as recommended in PEP-257 |
| 34 * `A110`: Write single-line string literals as represented by `repr()` | 34 * `A110`: Write single-line string literals as represented by `repr()` |
| 35 * `A111`: Redundant parantheses around if or while condition | 35 * `A111`: Redundant parantheses around if or while condition |
| 36 | 36 |
| 37 | 37 |
| 38 ### Redundancy and complexity | 38 ### Redundancy and complexity |
| 39 | 39 |
| 40 * `A201`: Redundant or superfluos `global` or `nonlocal` declaration | 40 * `A201`: Redundant or superfluos `global` or `nonlocal` declaration |
| 41 * `A202`: Dead code after block is left | 41 * `A202`: Dead code after block is left |
| 42 * `A303`: Unused expression | 42 * `A303`: Unused expression |
| 43 * `A204`: Redundant or superfluos pass statement | 43 * `A204`: Redundant or superfluos pass statement |
| 44 * `A205`: Superfluos empty block | 44 * `A205`: Superfluos empty block |
| 45 * `A206`: `else` statement after block is left | 45 * `A206`: Extraneous `else` statement after block is left |
|
Vasily Kuznetsov
2016/05/09 15:45:13
Maybe "Extraneous else" (in reference to https://w
Sebastian Noack
2016/05/09 16:49:12
Hehe, that talk is awesome. I saw it last year at
Vasily Kuznetsov
2016/05/09 17:37:33
Yeah, me too.
| |
| 46 * `A207`: Duplicate key in dict or set | 46 * `A207`: Duplicate key in dict or set |
| 47 | 47 |
| 48 | 48 |
| 49 ### Error-prone practices | 49 ### Error-prone practices |
| 50 | 50 |
| 51 * `A301`: Discouraged APIs | 51 * `A301`: Discouraged APIs |
| 52 * `A302`: Redefinition of built-in name | 52 * `A302`: Redefinition of built-in name |
| 53 * `A303`: Non-default source file encoding | 53 * `A303`: Non-default source file encoding |
| LEFT | RIGHT |
« .hgignore ('k')
|
flake8-abp/flake8_abp.py » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
