Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29340737: Issue 3968 - Add "new-" prefix to option file names (Closed)
Left Patch Set: Created April 22, 2016, 9:21 a.m.
Right Patch Set: Updated sentence about firstRun parameters for consistency. Created April 22, 2016, 12:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | ext/background.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 Shared Adblock Plus UI code 1 Shared Adblock Plus UI code
2 =========================== 2 ===========================
3 3
4 The user interface elements defined in this repository will be used by various 4 The user interface elements defined in this repository will be used by various
5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be
6 tested within this repository, even though they might not work exactly the same 6 tested within this repository, even though they might not work exactly the same
7 as they will do in the final product. 7 as they will do in the final product.
8 8
9 Directory structure 9 Directory structure
10 ------------------- 10 -------------------
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 the command line. (You will also need the Crowdin API key for the project.) 53 the command line. (You will also need the Crowdin API key for the project.)
54 54
55 firstRun.html 55 firstRun.html
56 ------------- 56 -------------
57 57
58 This is the implementation of the Adblock Plus first-run page that will show up 58 This is the implementation of the Adblock Plus first-run page that will show up
59 whenever changes are applied automatically to user's Adblock Plus configuration. 59 whenever changes are applied automatically to user's Adblock Plus configuration.
60 This will usually happen when the user first installs Adblock Plus (initial 60 This will usually happen when the user first installs Adblock Plus (initial
61 setup), but it can also happen in case the user's settings get lost. 61 setup), but it can also happen in case the user's settings get lost.
62 62
63 The behavior of this page is affected by a number of URL parameters: 63 To aid testing, the behavior of this page is affected by a number of URL
64 parameters:
64 65
65 * `platform`, `platformVersion`, `application`, `applicationVersion`: sets 66 * `platform`, `platformVersion`, `application`, `applicationVersion`: sets
66 application parameters that are normally determined by Adblock Plus. Using 67 application parameters that are normally determined by Adblock Plus. Using
67 `?platform=safari&platformVersion=5.0` should trigger a warning. 68 `?platform=safari&platformVersion=5.0` should trigger a warning.
68 * `filterlistsReinitialized`: setting these parameters to `true` should 69 * `filterlistsReinitialized`: setting these parameters to `true` should
69 trigger warnings referring to issues detected by Adblock Plus. 70 trigger warnings referring to issues detected by Adblock Plus.
70 * `blockedURLs`: a comma-separated list of URLs that should be considered 71 * `blockedURLs`: a comma-separated list of URLs that should be considered
71 blocked (necessary to test the check for blocked scripts in sharing buttons). 72 blocked (necessary to test the check for blocked scripts in sharing buttons).
72 73
73 new-options.html 74 new-options.html
74 ------------ 75 ------------
75 76
76 This is the new implementation of the Adblock Plus options page which will be 77 This is the new implementation of the Adblock Plus options page which will be
77 the primary UI for changing settings and for managing filter lists. 78 the primary UI for changing settings and for managing filter lists.
78 79
79 To aid testing, the behavior of this page is affected by a number of URL 80 To aid testing, the behavior of this page is affected by a number of URL
Thomas Greiner 2016/04/22 12:08:36 Detail: This sentence was copied from the first-ru
kzar 2016/04/22 12:24:00 Done.
80 parameters: 81 parameters:
81 82
82 * `addonVersion`: sets addon version application parameter that is used for 83 * `addonVersion`: sets addon version application parameter that is used for
83 creating the link to the version-specific release notes 84 creating the link to the version-specific release notes
84 * `addSubscription=true`: this parameter should trigger a dialog for adding 85 * `addSubscription=true`: this parameter should trigger a dialog for adding
85 subscriptions as initiated by clicking on an "abp:subscribe" link 86 subscriptions as initiated by clicking on an "abp:subscribe" link
86 * `filterError=true`: causes filter validation to fail, showing validation 87 * `filterError=true`: causes filter validation to fail, showing validation
87 errors when adding new filters on the options page 88 errors when adding new filters on the options page
88 * `blockedURLs`: a comma-separated list of URLs that should be considered 89 * `blockedURLs`: a comma-separated list of URLs that should be considered
89 blocked (necessary to test the check for blocked scripts in sharing buttons). 90 blocked (necessary to test the check for blocked scripts in sharing buttons).
90 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used 91 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used
91 to trigger various filter list download errors 92 to trigger various filter list download errors
92 * `platform=chromium`: shows the opt-out for the developer tools panel 93 * `platform=chromium`: shows the opt-out for the developer tools panel
93 * `safariContentBlocker=true`: sets Safari content blocker mock API 94 * `safariContentBlocker=true`: sets Safari content blocker mock API
94 * `showNotificationUI=true`: simulates user having opted-out of notifications 95 * `showNotificationUI=true`: simulates user having opted-out of notifications
95 96
96 97
97 [crowdin]: https://crowdin.com 98 [crowdin]: https://crowdin.com
LEFTRIGHT
« no previous file | ext/background.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld