Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29340967: Issue 3971 - Refactor away Object.observe (Closed)

Created:
April 29, 2016, 12:42 p.m. by kzar
Modified:
May 23, 2016, 10:31 a.m.
Reviewers:
Sebastian Noack
CC:
Thomas Greiner, saroyanm
Visibility:
Public.

Description

Issue 3971 - Refactor away Object.observe (Based on changes in https://codereview.adblockplus.org/29340970/ )

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -103 lines) Patch
M new-options.js View 4 chunks +66 lines, -103 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
April 29, 2016, 12:46 p.m. (2016-04-29 12:46:05 UTC) #1
kzar
On 2016/04/29 12:46:05, kzar wrote: > Patch Set 1 I forgot to mention, my aim ...
April 29, 2016, 12:52 p.m. (2016-04-29 12:52:14 UTC) #2
kzar
Thomas mentioned in IRC that as he's going on holiday soon someone else should review ...
April 29, 2016, 8:48 p.m. (2016-04-29 20:48:59 UTC) #3
saroyanm
I can have a look on Friday.
May 4, 2016, 2:40 p.m. (2016-05-04 14:40:17 UTC) #4
Sebastian Noack
May 4, 2016, 2:45 p.m. (2016-05-04 14:45:46 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld