Noissue - Several trivial code improvements (adblockplusui)

new-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 34 matching lines @@
     var placeholder = table.querySelector(".empty-placeholder");
     if (text && !placeholder)
     {
       placeholder = document.createElement("li");
       placeholder.className = "empty-placeholder";
       placeholder.textContent = getMessage(text);
       table.appendChild(placeholder);
     }
     else if (placeholder)
       table.removeChild(placeholder);
-  }
+  };
 
   Collection.prototype._createElementQuery = function(item)
   {
     var access = (item.url || item.text).replace(/'/g, "\\'");
     return function(container)
     {
       return container.querySelector("[data-access='" + access + "']");
     };
   };
 
   Collection.prototype._getItemTitle = function(item, i)
   {
     if (item.url == acceptableAdsUrl)
       return getMessage("options_acceptableAds_description");
     if (this.details[i].useOriginalTitle && item.originalTitle)
       return item.originalTitle;
     return item.title || item.url || item.text;
   };
 
-  Collection.prototype.addItems = function() 
+  Collection.prototype.addItems = function()
   {
     var length = Array.prototype.push.apply(this.items, arguments);
     if (length == 0)
       return;
 
     this.items.sort(function(a, b)
     {
       // Make sure that Acceptable Ads is always last, since it cannot be
       // disabled, but only be removed. That way it's grouped together with
       // the "Own filter list" which cannot be disabled either at the bottom
       // of the filter lists in the Advanced tab.
       if (a.url == acceptableAdsUrl)
         return 1;
       if (b.url == acceptableAdsUrl)
         return -1;
 
       var aTitle = this._getItemTitle(a, 0).toLowerCase();
       var bTitle = this._getItemTitle(b, 0).toLowerCase();
       return aTitle.localeCompare(bTitle);
     }.bind(this));
 
-    for (var j = 0; j < this.details.length; j++) 
+    for (var j = 0; j < this.details.length; j++)
     {
       var table = E(this.details[j].id);
       var template = table.querySelector("template");
-      for (var i = 0; i < arguments.length; i++) 
+      for (var i = 0; i < arguments.length; i++)
       {
         var item = arguments[i];
         var listItem = document.createElement("li");
         listItem.appendChild(document.importNode(template.content, true));
         listItem.setAttribute("data-access", item.url || item.text);
 
         var labelId = "label-" + (++maxLabelId);
         var label = listItem.querySelector(".display");
         label.setAttribute("id", labelId);
 
         var control = listItem.querySelector(".control");
         if (control)
         {
           control.setAttribute("aria-labelledby", labelId);
           control.addEventListener("click", this.details[j].onClick, false);
 
           var role = control.getAttribute("role");
           if (role == "checkbox" && !label.hasAttribute("data-action"))
           {
             var controlId = "control-" + maxLabelId;
             control.setAttribute("id", controlId);
             label.setAttribute("for", controlId);
           }
         }
 
         this._setEmpty(table, null);
         if (table.hasChildNodes())
         {
-          table.insertBefore(listItem, 
+          table.insertBefore(listItem,
               table.childNodes[this.items.indexOf(item)]);
         }
         else
           table.appendChild(listItem);
         this.updateItem(item);
       }
     }
     return length;
   };
 
@@ skipping 710 matching lines @@
     },
     function(subscriptions)
     {
       // Load filters
       for (var i = 0; i < subscriptions.length; i++)
       {
         ext.backgroundPage.sendMessage(
         {
           type: "filters.get",
           subscriptionUrl: subscriptions[i].url
-        }, 
+        },
         function(filters)
         {
           for (var i = 0; i < filters.length; i++)
             updateFilter(filters[i]);
         });
       }
     });
     loadRecommendations();
     ext.backgroundPage.sendMessage(
     {
       type: "prefs.get",
       key: "subscriptions_exceptionsurl"
     },
     function(url)
     {
       acceptableAdsUrl = url;
       updateSubscription({
         url: acceptableAdsUrl,
         disabled: true
       });
 
       // Load user subscriptions
       ext.backgroundPage.sendMessage(
       {
         type: "subscriptions.get",
         downloadable: true
-      }, 
+      },
       function(subscriptions)
       {
         for (var i = 0; i < subscriptions.length; i++)
           onSubscriptionMessage("added", subscriptions[i]);
       });
     });
   }
 
   function addWhitelistedDomain()
   {
@@ skipping 18 matching lines @@
     for (var i = 0; i < customFilterItems.length; i++)
       filterTexts.push(customFilterItems[i].text);
     E("custom-filters-raw").value = filterTexts.join("\n");
   }
 
   function addEnableSubscription(url, title, homepage)
   {
     var messageType = null;
     var knownSubscription = subscriptionsMap[url];
     if (knownSubscription && knownSubscription.disabled == true)
-      messageType = "subscriptions.toggle"
+      messageType = "subscriptions.toggle";
     else
-      messageType = "subscriptions.add"
+      messageType = "subscriptions.add";
 
     var message = {
       type: messageType,
       url: url
     };
     if (title)
       message.title = title;
     if (homepage)
       message.homepage = homepage;
 
@@ skipping 123 matching lines @@
 
     var checkbox = document.querySelector("[data-pref='" + key + "'] button[role='checkbox']");
     if (checkbox)
       checkbox.setAttribute("aria-checked", value);
   }
 
   function onShareLinkClick(e)
   {
     e.preventDefault();
 
-    getDocLink("share-general", function(link)
-    {
-      openSharePopup(link);
-    });
+    getDocLink("share-general", openSharePopup);
   }
 
   function updateShareLink()
   {
     var shareResources = [
       "https://facebook.com/plugins/like.php?",
       "https://platform.twitter.com/widgets/",
       "https://apis.google.com/se/0/_/+1/fastbutton?"
     ];
     var isAnyBlocked = false;
@@ skipping 70 matching lines @@
   });
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
         "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();