Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29341117: Issue 3766 - Restore default ABP bookmarks

Created:
May 10, 2016, 10:41 a.m. by dlima
Modified:
May 10, 2016, 3:40 p.m.
Reviewers:
René Jeschke
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3766 - Restore default ABP bookmarks

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding missing bookmarks #

Patch Set 3 : Removing default bookmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M mobile/android/base/locales/en-US/android_strings.dtd View 1 2 1 chunk +8 lines, -10 lines 0 comments Download
M mobile/android/base/strings.xml.in View 1 1 chunk +13 lines, -1 line 0 comments Download
M mobile/android/tests/browser/robocop/src/org/mozilla/gecko/tests/StringHelper.java View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5
dlima
May 10, 2016, 1:47 p.m. (2016-05-10 13:47:24 UTC) #1
René Jeschke
https://codereview.adblockplus.org/29341117/diff/29341118/mobile/android/base/locales/en-US/android_strings.dtd File mobile/android/base/locales/en-US/android_strings.dtd (right): https://codereview.adblockplus.org/29341117/diff/29341118/mobile/android/base/locales/en-US/android_strings.dtd#newcode759 mobile/android/base/locales/en-US/android_strings.dtd:759: <!ENTITY bookmarks_acceptableads "Acceptable Ads"> Could you please also remove ...
May 10, 2016, 2:03 p.m. (2016-05-10 14:03:56 UTC) #2
dlima
On 2016/05/10 14:03:56, René Jeschke wrote: > https://codereview.adblockplus.org/29341117/diff/29341118/mobile/android/base/locales/en-US/android_strings.dtd > File mobile/android/base/locales/en-US/android_strings.dtd (right): > > https://codereview.adblockplus.org/29341117/diff/29341118/mobile/android/base/locales/en-US/android_strings.dtd#newcode759 ...
May 10, 2016, 3:37 p.m. (2016-05-10 15:37:00 UTC) #3
dlima
May 10, 2016, 3:37 p.m. (2016-05-10 15:37:09 UTC) #4
René Jeschke
May 10, 2016, 3:40 p.m. (2016-05-10 15:40:03 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld