Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29341301: Issue 3113 - Controls in Find in Page UI are white on near-white and look missing (Closed)

Created:
May 12, 2016, 9:13 a.m. by diegocarloslima
Modified:
Oct. 25, 2016, 3:45 p.m.
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 3113 - Controls in Find in Page UI are white on near-white and look missing

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changing drawables as requested in code review #

Messages

Total messages: 4
diegocarloslima
May 12, 2016, 9:14 a.m. (2016-05-12 09:14:11 UTC) #1
René Jeschke
https://codereview.adblockplus.org/29341301/diff/29341302/mobile/android/base/resources/values/styles.xml File mobile/android/base/resources/values/styles.xml (right): https://codereview.adblockplus.org/29341301/diff/29341302/mobile/android/base/resources/values/styles.xml#newcode588 mobile/android/base/resources/values/styles.xml:588: <item name="android:background">@color/background_tabs</item> Our style guide says that icons are ...
May 30, 2016, 9:10 a.m. (2016-05-30 09:10:00 UTC) #2
anton
On 2016/05/12 09:14:11, diegocarloslima wrote: LGTM
Sept. 30, 2016, 7:06 a.m. (2016-09-30 07:06:22 UTC) #3
Felix Dahlke
Sept. 30, 2016, 7:21 a.m. (2016-09-30 07:21:07 UTC) #4
LGTM!

One of the few issues we have in ABB that annoys me personally on a regular
basis :D

Powered by Google App Engine
This is Rietveld