Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(710)

Issue 29341317: Issue 3199 - "Firefox" string is displayed on several error messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by diegocarloslima
Modified:
11 months, 2 weeks ago
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 3199 - "Firefox" string is displayed on several error messages Sibling review for this issue: https://codereview.adblockplus.org/29348650/

Patch Set 1 #

Patch Set 2 : Replacing one occurrence in sync_strings.dtd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M mobile/android/base/locales/en-US/sync_strings.dtd View 1 1 chunk +1 line, -1 line 0 comments Download
M mobile/locales/en-US/overrides/appstrings.properties View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 8
diegocarloslima
1 year, 7 months ago (2016-05-12 12:46:10 UTC) #1
René Jeschke
On 2016/05/12 12:46:10, diegocarloslima wrote: Sadly, the solution to this is not that easy. Changing ...
1 year, 6 months ago (2016-05-30 09:16:46 UTC) #2
anton
On 2016/05/30 09:16:46, René Jeschke wrote: > On 2016/05/12 12:46:10, diegocarloslima wrote: > > Sadly, ...
1 year, 2 months ago (2016-09-30 06:53:11 UTC) #3
diegocarloslima
On 2016/09/30 06:53:11, anton wrote: > On 2016/05/30 09:16:46, René Jeschke wrote: > > On ...
1 year, 1 month ago (2016-10-24 15:45:54 UTC) #4
anton
On 2016/10/24 15:45:54, diegocarloslima wrote: > On 2016/09/30 06:53:11, anton wrote: > > On 2016/05/30 ...
1 year, 1 month ago (2016-11-07 07:29:06 UTC) #5
Felix Dahlke
Shouldn't this be covered by the automated replacement logic you introduced in https://codereview.adblockplus.org/29348650/?
1 year ago (2016-12-13 13:18:25 UTC) #6
diegocarloslima
On 2016/12/13 13:18:25, Felix Dahlke wrote: > Shouldn't this be covered by the automated replacement ...
11 months, 4 weeks ago (2016-12-21 13:30:04 UTC) #7
Felix Dahlke
11 months, 3 weeks ago (2016-12-21 19:19:45 UTC) #8
I see. No incredibly strong opinion. Maybe it's helpful during an upstream merge
to stay on top of what strings we are changing. LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5