Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29341330: Issue 3135 - Show the first run slide about the beta community to users that installed via Play and… (Closed)

Created:
May 12, 2016, 3:21 p.m. by diegocarloslima
Modified:
Dec. 12, 2016, 3:45 p.m.
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 3135 - Show the first run slide about the beta community to users that installed via Play and…

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M mobile/android/base/BrowserApp.java View 1 chunk +1 line, -6 lines 2 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/BrowserAppUtils.java View 2 chunks +7 lines, -0 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/StartPane.java View 5 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 6
diegocarloslima
May 12, 2016, 3:22 p.m. (2016-05-12 15:22:09 UTC) #1
anton
https://codereview.adblockplus.org/29341330/diff/29341331/mobile/android/base/BrowserApp.java File mobile/android/base/BrowserApp.java (right): https://codereview.adblockplus.org/29341330/diff/29341331/mobile/android/base/BrowserApp.java#newcode3561 mobile/android/base/BrowserApp.java:3561: AppConstants.ABB_RELEASE_BUILD && org.adblockplus.browser.BrowserAppUtils.wasInstalledFromPlayStore(this)) { what the point of using ...
Sept. 12, 2016, 11:36 a.m. (2016-09-12 11:36:11 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29341330/diff/29341331/mobile/android/base/BrowserApp.java File mobile/android/base/BrowserApp.java (right): https://codereview.adblockplus.org/29341330/diff/29341331/mobile/android/base/BrowserApp.java#newcode3561 mobile/android/base/BrowserApp.java:3561: AppConstants.ABB_RELEASE_BUILD && org.adblockplus.browser.BrowserAppUtils.wasInstalledFromPlayStore(this)) { On 2016/09/12 11:36:11, anton wrote: ...
Oct. 20, 2016, 12:18 p.m. (2016-10-20 12:18:08 UTC) #3
diegocarloslima
On 2016/10/20 12:18:08, diegocarloslima wrote: > https://codereview.adblockplus.org/29341330/diff/29341331/mobile/android/base/BrowserApp.java > File mobile/android/base/BrowserApp.java (right): > > https://codereview.adblockplus.org/29341330/diff/29341331/mobile/android/base/BrowserApp.java#newcode3561 > ...
Oct. 21, 2016, 1:22 p.m. (2016-10-21 13:22:50 UTC) #4
anton
On 2016/10/21 13:22:50, diegocarloslima wrote: > On 2016/10/20 12:18:08, diegocarloslima wrote: > > > https://codereview.adblockplus.org/29341330/diff/29341331/mobile/android/base/BrowserApp.java ...
Nov. 2, 2016, 2:09 p.m. (2016-11-02 14:09:35 UTC) #5
Felix Dahlke
Dec. 1, 2016, 5:30 p.m. (2016-12-01 17:30:41 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld