Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29341344: Noissue - Run flake8 on all Python versions (Closed)

Created:
May 12, 2016, 3:39 p.m. by Sebastian Noack
Modified:
May 27, 2016, 1:37 p.m.
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Noissue - Run flake8 on all Python versions

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M tox.ini View 1 1 chunk +14 lines, -13 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
May 12, 2016, 3:39 p.m. (2016-05-12 15:39:33 UTC) #1
Vasily Kuznetsov
This looks good, but I'd prefer to make flake8-abp recognise that `from __future__ import unicode_literals` ...
May 12, 2016, 4:05 p.m. (2016-05-12 16:05:57 UTC) #2
Sebastian Noack
On 2016/05/12 16:05:57, Vasily Kuznetsov wrote: > This looks good, but I'd prefer to make ...
May 12, 2016, 4:17 p.m. (2016-05-12 16:17:34 UTC) #3
Sebastian Noack
On 2016/05/12 16:17:34, Sebastian Noack wrote: > that we should account for that (somehow) in ...
May 12, 2016, 4:22 p.m. (2016-05-12 16:22:40 UTC) #4
Vasily Kuznetsov
May 27, 2016, 1:25 p.m. (2016-05-27 13:25:19 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld