patchconv/tox.ini - Issue 29341347: Noissue - Add a script for converting Rietveld patches to Git format

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: patchconv/tox.ini

Issue 29341347: Noissue - Add a script for converting Rietveld patches to Git format (Closed)

Left Patch Set: Address review comments Created May 12, 2016, 11:21 p.m.

Right Patch Set: Make flake8 check a bit more general in tox.ini Created May 17, 2016, 1:28 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [tox]	1 [tox]

2 envlist = py27, py35	2 envlist = py27, py35

3	3

4 [testenv]	4 [testenv]

5 deps =	5 deps =

6 pytest	6 pytest

7 pytest-cov	7 pytest-cov

8 mock	8 mock

9 flake8	9 flake8

10 pep8-naming	10 pep8-naming

11 ../flake8-abp	11 ../flake8-abp

12	12

13 commands =	13 commands =

14 py.test --cov=patchconv --cov-report term-missing tests	14 py.test --cov=patchconv --cov-report term-missing tests

15 flake8 patchconv.py setup.py tests/test_rietveld_to_git.py	15 flake8 patchconv.py setup.py tests
Sebastian Noack 2016/05/12 23:48:51 Note that flake8 can automatically find Python fil Note that flake8 can automatically find Python files. So instead hardcoding 3 files here, you could just use --exclude=build Vasily Kuznetsov 2016/05/17 15:57:30 This is nice, but in my opinion a bit too implicit Show quoted text On 2016/05/12 23:48:51, Sebastian Noack wrote: > Note that flake8 can automatically find Python files. So instead hardcoding 3 > files here, you could just use --exclude=build This is nice, but in my opinion a bit too implicit. So I removed the particular test, which is indeed redundant, but kept the other two python files as they were.
LEFT	RIGHT