Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: mobile/android/base/home/PanelAuthLayout.java

Issue 29341383: Issue 2606 - Firefox logo shown in background on empty Adblock Browser New Tab and Search pages (Closed)
Left Patch Set: Adding change comments Created Nov. 2, 2016, 10:47 a.m.
Right Patch Set: Adjustments in comments Created Nov. 21, 2016, 12:59 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | mobile/android/base/home/PanelLayout.java » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*- 1 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-
2 * This Source Code Form is subject to the terms of the Mozilla Public 2 * This Source Code Form is subject to the terms of the Mozilla Public
3 * License, v. 2.0. If a copy of the MPL was not distributed with this 3 * License, v. 2.0. If a copy of the MPL was not distributed with this
4 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 4 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
5 5
6 package org.mozilla.gecko.home; 6 package org.mozilla.gecko.home;
7 7
8 import org.mozilla.gecko.GeckoAppShell; 8 import org.mozilla.gecko.GeckoAppShell;
9 import org.mozilla.gecko.GeckoEvent; 9 import org.mozilla.gecko.GeckoEvent;
10 import org.mozilla.gecko.R; 10 import org.mozilla.gecko.R;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 @Override 46 @Override
47 public void onClick(View v) { 47 public void onClick(View v) {
48 GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent(" HomePanels:Authenticate", panelId)); 48 GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent(" HomePanels:Authenticate", panelId));
49 } 49 }
50 }); 50 });
51 51
52 final ImageView imageView = (ImageView) findViewById(R.id.image); 52 final ImageView imageView = (ImageView) findViewById(R.id.image);
53 final String imageUrl = authConfig.getImageUrl(); 53 final String imageUrl = authConfig.getImageUrl();
54 54
55 if (TextUtils.isEmpty(imageUrl)) { 55 if (TextUtils.isEmpty(imageUrl)) {
56 // Use a default image if an image URL isn't specified.
56 // Changed icon. See https://issues.adblockplus.org/ticket/2606 57 // Changed icon. See https://issues.adblockplus.org/ticket/2606
Felix Dahlke 2016/11/17 18:38:51 Nit: Makes more sense to me if you'd move this one
57 // Use a default image if an image URL isn't specified.
58 imageView.setImageResource(R.drawable.abb_icon_home_empty); 58 imageView.setImageResource(R.drawable.abb_icon_home_empty);
59 } else { 59 } else {
60 ImageLoader.with(getContext()) 60 ImageLoader.with(getContext())
61 .load(imageUrl) 61 .load(imageUrl)
62 .into(imageView); 62 .into(imageView);
63 } 63 }
64 } 64 }
65 } 65 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld