Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/home/PanelAuthLayout.java

Issue 29341383: Issue 2606 - Firefox logo shown in background on empty Adblock Browser New Tab and Search pages (Closed)
Patch Set: Adding change comments Created Nov. 2, 2016, 10:47 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mobile/android/base/home/PanelLayout.java » ('j') | mobile/android/base/home/PanelLayout.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mobile/android/base/home/PanelAuthLayout.java
===================================================================
--- a/mobile/android/base/home/PanelAuthLayout.java
+++ b/mobile/android/base/home/PanelAuthLayout.java
@@ -48,17 +48,18 @@ class PanelAuthLayout extends LinearLayo
GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent("HomePanels:Authenticate", panelId));
}
});
final ImageView imageView = (ImageView) findViewById(R.id.image);
final String imageUrl = authConfig.getImageUrl();
if (TextUtils.isEmpty(imageUrl)) {
+ // Changed icon. See https://issues.adblockplus.org/ticket/2606
Felix Dahlke 2016/11/17 18:38:51 Nit: Makes more sense to me if you'd move this one
// Use a default image if an image URL isn't specified.
- imageView.setImageResource(R.drawable.icon_home_empty_firefox);
+ imageView.setImageResource(R.drawable.abb_icon_home_empty);
} else {
ImageLoader.with(getContext())
.load(imageUrl)
.into(imageView);
}
}
}
« no previous file with comments | « no previous file | mobile/android/base/home/PanelLayout.java » ('j') | mobile/android/base/home/PanelLayout.java » ('J')

Powered by Google App Engine
This is Rietveld