Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/home/PanelLayout.java

Issue 29341383: Issue 2606 - Firefox logo shown in background on empty Adblock Browser New Tab and Search pages (Closed)
Patch Set: Adding change comments Created Nov. 2, 2016, 10:47 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mobile/android/base/home/PanelLayout.java
===================================================================
--- a/mobile/android/base/home/PanelLayout.java
+++ b/mobile/android/base/home/PanelLayout.java
@@ -455,21 +455,23 @@ abstract class PanelLayout extends Frame
} else {
textView.setText(text);
}
final String imageUrl = (emptyViewConfig == null) ? null : emptyViewConfig.getImageUrl();
final ImageView imageView = (ImageView) view.findViewById(R.id.home_empty_image);
if (TextUtils.isEmpty(imageUrl)) {
- imageView.setImageResource(R.drawable.icon_home_empty_firefox);
+ // Changed icon. See https://issues.adblockplus.org/ticket/2606
Felix Dahlke 2016/11/17 18:38:51 Nit: I guess it would suffice to have this comment
+ imageView.setImageResource(R.drawable.abb_icon_home_empty);
} else {
+ // Changed icon. See https://issues.adblockplus.org/ticket/2606
ImageLoader.with(getContext())
.load(imageUrl)
- .error(R.drawable.icon_home_empty_firefox)
+ .error(R.drawable.abb_icon_home_empty)
.into(imageView);
}
viewState.setEmptyView(view);
}
return view;
}

Powered by Google App Engine
This is Rietveld