Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29341398: Issue 4041 - Missing engine startup synchronization causing 'blocker not available' message (Closed)

Created:
May 13, 2016, 10:42 a.m. by René Jeschke
Modified:
May 17, 2016, 9:30 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 4041 - Missing engine startup synchronization causing 'blocker not available' message

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -22 lines) Patch
M src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java View 4 chunks +27 lines, -4 lines 1 comment Download
M src/org/adblockplus/sbrowser/contentblocker/engine/EngineService.java View 5 chunks +53 lines, -18 lines 0 comments Download

Messages

Total messages: 3
René Jeschke
*sigh* ... another urgent SBrowser thingy ... should be the last before the next 'emergency' ...
May 13, 2016, 10:44 a.m. (2016-05-13 10:44:06 UTC) #1
Felix Dahlke
LGTM with just a nit. https://codereview.adblockplus.org/29341398/diff/29341399/src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java File src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java (right): https://codereview.adblockplus.org/29341398/diff/29341399/src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java#newcode104 src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java:104: Log.e(TAG, "Engine failed to ...
May 13, 2016, 2:29 p.m. (2016-05-13 14:29:09 UTC) #2
René Jeschke
May 17, 2016, 8:43 a.m. (2016-05-17 08:43:29 UTC) #3
On 2016/05/13 14:29:09, Felix Dahlke wrote:
> LGTM with just a nit.
> 
>
https://codereview.adblockplus.org/29341398/diff/29341399/src/org/adblockplus...
> File
> src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java
> (right):
> 
>
https://codereview.adblockplus.org/29341398/diff/29341399/src/org/adblockplus...
>
src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java:104:
> Log.e(TAG, "Engine failed to initialized");
> Nit: "failed to initialize" (minus the last d)

Of course :D will fix this :D

Powered by Google App Engine
This is Rietveld