lib/cssRules.js - Issue 29342830: Issue 4057 - Further speedup ElemHide.getSelectorsforDomain

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/cssRules.js

Issue 29342830: Issue 4057 - Further speedup ElemHide.getSelectorsforDomain (Closed)

Patch Set: Take care to remove filters from lookups Created May 20, 2016, 10:45 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/cssRules.js

diff --git a/lib/cssRules.js b/lib/cssRules.js

index 9fdbbba57f72df44494bec3f98f8a9e16ab7aeb9..b3682fadd342be27ff3658ba0bb133487d597ac8 100644

--- a/lib/cssRules.js

+++ b/lib/cssRules.js

@@ -68,7 +68,8 @@ let CSSRules = exports.CSSRules =

for (let key of keys)

{

let filter = Filter.fromText(key);

- if (filter.isActiveOnDomain(domain) && !ElemHide.getException(filter, domain))

+ if (filter.isActiveOnDomain(domain) &&

+ !ElemHide.getException(filter.selector, domain))

result.push(filter);

}

return result;

« no previous file with comments | « no previous file | lib/elemHide.js » ('j') | lib/elemHide.js » ('J')