Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/elemHide.js

Issue 29342837: Issue 4054 - Remove filters from filtersByDomain (Closed)
Patch Set: Rename domainMatches for consistency Created May 20, 2016, 1:30 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/elemHide.js
diff --git a/lib/elemHide.js b/lib/elemHide.js
index 6e2f1b56acbb6e67e79f779503b469f9d8829903..700db132d52c5ee81e90e3f122f6ac701a1d074c 100644
--- a/lib/elemHide.js
+++ b/lib/elemHide.js
@@ -157,14 +157,14 @@ var ElemHide = exports.ElemHide =
if (usingFiltersByDomain)
{
- let domainMatches = filter.domains || defaultDomains;
- for (let domain in domainMatches)
+ let domains = filter.domains || defaultDomains;
+ for (let domain in domains)
{
let filters = filtersByDomain[domain];
if (!filters)
filters = filtersByDomain[domain] = Object.create(null);
- if (domainMatches[domain])
+ if (domains[domain])
filters[filter.text] = filter;
else
filters[filter.text] = false;
@@ -201,6 +201,17 @@ var ElemHide = exports.ElemHide =
delete filterByKey[key];
delete keyByFilter[filter.text];
ElemHide.isDirty = true;
+
+ if (usingFiltersByDomain)
+ {
+ let domains = filter.domains || defaultDomains;
+ for (let domain in domains)
+ {
+ let filters = filtersByDomain[domain];
+ if (filters)
+ delete filters[filter.text];
+ }
+ }
}
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld