Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: test/stub-modules/prefs.js
Issue
29342884
:
Issue 4055 - Test ElemHide.getSelectorsFordomain (Closed)
Patch Set: Add test and note about known limitation.
Created May 22, 2016, 8:30 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Add test and note about known limitation.
Patch Set 3: Ignore selector order
Patch Set 4: Addressed feedback
Patch Set 5: Properly test and document duplicate selector behaviour
Patch Set 6: Simplify filter function and move comment
Right:
Patch Set 1: None
Patch Set 2: Add test and note about known limitation.
Patch Set 3: Ignore selector order
Patch Set 4: Addressed feedback
Patch Set 5: Properly test and document duplicate selector behaviour
Patch Set 6: Simplify filter function and move comment
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
package.json
test/elemHide.js
test/stub-modules/io.js
test/stub-modules/prefs.js
test/stub-modules/utils.js
View unified diff
|
Download patch
« no previous file with comments
|
« test/stub-modules/io.js
('k') |
test/stub-modules/utils.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
exports.Prefs = { };
OLD
NEW
« no previous file with comments
|
« test/stub-modules/io.js
('k') |
test/stub-modules/utils.js »
('j') |
no next file with comments »
Edit Message
Issue 29342884: Issue 4055 - Test ElemHide.getSelectorsFordomain (Closed)
Created May 22, 2016, 4:41 p.m. by kzar
Modified May 24, 2016, 8:08 a.m.
Reviewers: Wladimir Palant
Base URL:
Comments: 21
+ 2 drafts
This is Rietveld