Issue 4055 - Test ElemHide.getSelectorsFordomain

test/elemHide.js

Index: test/elemHide.js
diff --git a/test/elemHide.js b/test/elemHide.js
new file mode 100644
index 0000000000000000000000000000000000000000..1e88be7f2e924e0eb8665d90ee24329ac281dd5a
--- /dev/null
+++ b/test/elemHide.js
@@ -0,0 +1,158 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2016 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+"use strict";
+
+GLOBAL.Ci = {};
+GLOBAL.Cu = {
+  import: function()
+  {
+  }
+};
+
+let {ElemHide} = require("elemHide");
+let {Filter} = require("filterClasses");
+
+exports.testGetSelectorsForDomain = function(test)
+{
+  function fromText(f)
+  {
+    return (filterText) => f(Filter.fromText(filterText));
+  }
+  let addFilter = fromText(ElemHide.add);
+  let removeFilter = fromText(ElemHide.remove);
+
+  function selectorsEqual(domain, selectors, specificOnly)
+  {
+    test.deepEqual(ElemHide.getSelectorsForDomain(domain, specificOnly).sort(),
+                   selectors.sort());
+  }
+
+  selectorsEqual("", []);
+
+  addFilter("~foo.example.com,example.com##foo");
+  selectorsEqual("barfoo.example.com", ["foo"]);
+  selectorsEqual("bar.foo.example.com", []);
+  selectorsEqual("foo.example.com", []);
+  selectorsEqual("example.com", ["foo"]);
+  selectorsEqual("com", []);
+  selectorsEqual("", []);
+
+  addFilter("foo.example.com##turnip");
+  selectorsEqual("foo.example.com", ["turnip"]);
+  selectorsEqual("example.com", ["foo"]);
+  selectorsEqual("com", []);
+  selectorsEqual("", []);
+
+  addFilter("example.com#@#foo");
+  selectorsEqual("foo.example.com", ["turnip"]);
+  selectorsEqual("example.com", []);
+  selectorsEqual("com", []);
+  selectorsEqual("", []);
+
+  addFilter("com##bar");
+  selectorsEqual("foo.example.com", ["turnip", "bar"]);
+  selectorsEqual("example.com", ["bar"]);
+  selectorsEqual("com", ["bar"]);
+  selectorsEqual("", []);
+
+  addFilter("example.com#@#bar");
+  selectorsEqual("foo.example.com", ["turnip"]);
+  selectorsEqual("example.com", []);
+  selectorsEqual("com", ["bar"]);
+  selectorsEqual("", []);
+
+  removeFilter("example.com#@#foo");
+  selectorsEqual("foo.example.com", ["turnip"]);
+  selectorsEqual("example.com", ["foo"]);
+  selectorsEqual("com", ["bar"]);
+  selectorsEqual("", []);
+
+  removeFilter("example.com#@#bar");
+  selectorsEqual("foo.example.com", ["turnip", "bar"]);
+  selectorsEqual("example.com", ["foo", "bar"]);
+  selectorsEqual("com", ["bar"]);
+  selectorsEqual("", []);
+
+  addFilter("##generic");
+  selectorsEqual("foo.example.com", ["turnip", "bar", "generic"]);
+  selectorsEqual("example.com", ["foo", "bar", "generic"]);
+  selectorsEqual("com", ["bar", "generic"]);
+  selectorsEqual("", ["generic"]);
+  selectorsEqual("foo.example.com", ["turnip", "bar"], true);
+  selectorsEqual("example.com", ["foo", "bar"], true);
+  selectorsEqual("com", ["bar"], true);
+  selectorsEqual("", [], true);
+  removeFilter("##generic");
+
+  addFilter("~adblockplus.org##example");
+  selectorsEqual("adblockplus.org", []);
+  selectorsEqual("", ["example"]);
+  selectorsEqual("foo.example.com", ["turnip", "bar", "example"]);
+  selectorsEqual("foo.example.com", ["turnip", "bar"], true);
+  removeFilter("~adblockplus.org##example");
+
+  removeFilter("~foo.example.com,example.com##foo");
+  selectorsEqual("foo.example.com", ["turnip", "bar"]);
+  selectorsEqual("example.com", ["bar"]);
+  selectorsEqual("com", ["bar"]);
+  selectorsEqual("", []);
+
+  removeFilter("com##bar");
+  selectorsEqual("foo.example.com", ["turnip"]);
+  selectorsEqual("example.com", []);
+  selectorsEqual("com", []);
+  selectorsEqual("", []);
+
+  removeFilter("foo.example.com##turnip");
+  selectorsEqual("foo.example.com", []);
+  selectorsEqual("example.com", []);
+  selectorsEqual("com", []);
+  selectorsEqual("", []);
+
+  addFilter("example.com##dupe");
+  addFilter("example.com##dupe");
+  selectorsEqual("example.com", ["dupe"]);
+  removeFilter("example.com##dupe");
+  selectorsEqual("example.com", []);
+  removeFilter("example.com##dupe");
+
+  addFilter("~foo.example.com,example.com##foo");
+
+  addFilter("##foo");
+  selectorsEqual("foo.example.com", ["foo"]);
+  selectorsEqual("example.com", ["foo", "foo"]);

[Wladimir Palant, 2016/05/23 15:06:47]

Here you are cementing what is considerably a bug in the current implementation.
Instead, you should make sure that selectorsEqual will remove duplicates in
addition to sorting the list - and note in a comment that getSelectorsByDomain
is currently allowed to return duplicates for performance reasons.

[kzar, 2016/05/23 15:49:19]

Done.

+  selectorsEqual("com", ["foo"]);
+  selectorsEqual("", ["foo"]);
+  removeFilter("##foo");
+
+  addFilter("example.org##foo");
+  selectorsEqual("foo.example.com", []);
+  selectorsEqual("example.com", ["foo"]);
+  selectorsEqual("com", []);
+  selectorsEqual("", []);
+  removeFilter("example.org##foo");
+
+  addFilter("~example.com##foo");
+  selectorsEqual("foo.example.com", []);
+  selectorsEqual("example.com", ["foo"]);
+  selectorsEqual("com", ["foo"]);
+  selectorsEqual("", ["foo"]);
+  removeFilter("example.org##foo");
+
+  test.done();
+};