Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/ext/background.js

Issue 29342909: Issue 4020 - In Edge, rawSender.url is not always defined (Closed)
Patch Set: Created May 23, 2016, 5:45 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/ext/background.js
diff --git a/chrome/ext/background.js b/chrome/ext/background.js
index d9735e21c9399a81955d18ace5a8d98026c553fa..6ac8e4fb7fa158cdae26fac9b32d13f83997f29d 100644
--- a/chrome/ext/background.js
+++ b/chrome/ext/background.js
@@ -501,7 +501,7 @@
{
sender.page = new Page(rawSender.tab);
sender.frame = {
- url: new URL(rawSender.url),
+ url: rawSender.url ? new URL(rawSender.url): '',
Sebastian Noack 2016/05/27 11:58:47 I think it would be more appropriate to set URL to
get parent()
{
var frames = framesOfTabs[rawSender.tab.id];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld