chrome/ext/background.js - Issue 29342909: Issue 4020 - In Edge, rawSender.url is not always defined

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/ext/background.js

Issue 29342909: Issue 4020 - In Edge, rawSender.url is not always defined (Closed)

Patch Set: Use null instead of an empty string. Add a description comment. Created May 28, 2016, 10:28 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/ext/background.js

diff --git a/chrome/ext/background.js b/chrome/ext/background.js

index 87f2209df71e3565730add28c3ca7a0f9b263ff2..6ebcbb17513885fdd9d1a3f927abc6d87ce6a320 100644

--- a/chrome/ext/background.js

+++ b/chrome/ext/background.js

@@ -501,7 +501,9 @@

{

sender.page = new Page(rawSender.tab);

sender.frame = {

- url: new URL(rawSender.url),

+ // In Edge requests from internal extension pages

+ // (protocol ms-browser-extension://) do no have a sender URL.

+ url: rawSender.url ? new URL(rawSender.url): null,

Sebastian Noack 2016/05/29 13:53:59 Nit: Please add a space before the colon.

get parent()

{

var frames = framesOfTabs[rawSender.tab.id];

« no previous file with comments | « no previous file | no next file » | no next file with comments »