Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/ext/background.js

Issue 29342909: Issue 4020 - In Edge, rawSender.url is not always defined (Closed)
Patch Set: Add space before the column Created May 30, 2016, 12:35 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/ext/background.js
diff --git a/chrome/ext/background.js b/chrome/ext/background.js
index 87f2209df71e3565730add28c3ca7a0f9b263ff2..a305d1154c83e29d9e4dfcebd581537bc9b94a02 100644
--- a/chrome/ext/background.js
+++ b/chrome/ext/background.js
@@ -501,7 +501,9 @@
{
sender.page = new Page(rawSender.tab);
sender.frame = {
- url: new URL(rawSender.url),
+ // In Edge requests from internal extension pages
+ // (protocol ms-browser-extension://) do no have a sender URL.
+ url: rawSender.url ? new URL(rawSender.url) : null,
get parent()
{
var frames = framesOfTabs[rawSender.tab.id];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld