Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/resources/xml-v11/preferences_abb_abp.xml

Issue 29342912: Issue 3070 - Create Adblock Plus on/off switch (Closed)
Patch Set: Created May 23, 2016, 11:02 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mobile/android/base/resources/xml-v11/preferences_abb_abp.xml
===================================================================
--- a/mobile/android/base/resources/xml-v11/preferences_abb_abp.xml
+++ b/mobile/android/base/resources/xml-v11/preferences_abb_abp.xml
@@ -1,32 +1,39 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:gecko="http://schemas.android.com/apk/res-auto" >
- <PreferenceCategory android:title="@string/abb_pref_category_blocking">
+ <org.adblockplus.browser.AbpCheckBoxPreference android:defaultValue="true"
anton 2016/09/30 07:18:21 i can see previously `android:title` was the first
diegocarloslima 2016/10/26 12:34:17 I've just looked into our sources and it seems tha
+ android:key="android.not_a_preference.adblockbrowser.apiAdblockPlusEnabled"
+ android:persistent="false" android:summary="@string/abb_pref_category_abp_summary"
+ android:title="@string/abb_pref_category_abp" />
+
+ <PreferenceCategory android:dependency="android.not_a_preference.adblockbrowser.apiAdblockPlusEnabled"
+ android:title="@string/abb_pref_category_blocking">
anton 2016/09/30 07:18:21 reorder to make the first again?
<PreferenceScreen android:title="@string/abb_pref_category_adblocking"
android:summary="@string/abb_pref_category_adblocking_summary"
android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment" >
<extra android:name="resource"
android:value="preferences_abb_adblocking" />
</PreferenceScreen>
<PreferenceScreen android:title="@string/abb_pref_category_more_blocking"
android:summary="@string/abb_pref_category_more_blocking_summary"
android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment" >
<extra android:name="resource"
android:value="preferences_abb_more_blocking" />
</PreferenceScreen>
</PreferenceCategory>
- <PreferenceCategory android:title="@string/abb_pref_category_exceptions">
+ <PreferenceCategory android:dependency="android.not_a_preference.adblockbrowser.apiAdblockPlusEnabled"
+ android:title="@string/abb_pref_category_exceptions">
anton 2016/09/30 07:18:21 reorder to make the first again?
<PreferenceScreen android:title="@string/abb_pref_category_acceptable_ads"
android:summary="@string/abb_pref_category_acceptable_ads_summary"
android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment" >
<extra android:name="resource"
android:value="preferences_abb_abp_acceptable_ads" />
</PreferenceScreen>
<!-- Commented out until implemented
<PreferenceScreen android:title="@string/abb_pref_category_whitelisted_sites"

Powered by Google App Engine
This is Rietveld