tox.ini - Issue 29342955: Issue 3985 - Unified test runner for sitescripts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tox.ini

Issue 29342955: Issue 3985 - Unified test runner for sitescripts (Closed)

Left Patch Set: Remove filterhits, remove dependencies for notifications tests, make everything run in one environm… Created May 24, 2016, 6:09 p.m.

Right Patch Set: Measure test coverage of everything in sitescripts Created May 25, 2016, 3:37 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [tox]	1 [tox]

2 envlist = py27	2 envlist = py27

3 skipsdist = true	3 skipsdist = true

4	4

5 [pytest]	5 [pytest]

6 # The names of the test files here don't start with 'test_' so we need	6 # The names of the test files here don't start with 'test_' so we need

7 # to instruct pytest to load tests from all files.	7 # to instruct pytest to load tests from all files.

8 python_files = *.py	8 python_files = *.py

9	9

10 [run]	10 [run]

11 # Exclude tests from coverage.	11 # Exclude tests from coverage.

12 omit = /test/	12 omit = /test/

13	13

14 [testenv]	14 [testenv]

15 basepython=python2	15 basepython=python2

16 deps =	16 deps =

17 pytest	17 pytest

18 pytest-cov	18 pytest-cov

19 mock	19 mock

20 jinja2	20 jinja2

	21 flake8

	22 pysed

	23

21 setenv =	24 setenv =

22 SITESCRIPTS_CONFIG = ./.sitescripts.test	25 SITESCRIPTS_CONFIG = ./.sitescripts.test

23 whitelist_externals =	26 whitelist_externals = cp

24 bash

25 rm

26 commands =	27 commands =

27 bash -c "sed -e 's/sitescripts\.[a-zA-Z_]\.web./# &/' .sitescripts.example >.sitescripts.test"	28 cp .sitescripts.example .sitescripts.test
Sebastian Noack 2016/05/25 07:51:36 Perhaps we should only exclude the web handlers th Perhaps we should only exclude the web handlers that will cause an ImportError. For the other handlers, it's a nice side effect to have implicitly tested whether they can be imported at least. Vasily Kuznetsov 2016/05/25 15:17:40 Done. Show quoted text On 2016/05/25 07:51:36, Sebastian Noack wrote: > Perhaps we should only exclude the web handlers that will cause an ImportError. > For the other handlers, it's a nice side effect to have implicitly tested > whether they can be imported at least. Done.
	29 pysed \

	30 -r sitescripts\.(reports\|filterhits\|testpages\|crawler\|urlfixer)\.web.* \

	31 '' .sitescripts.test --write

28 python ensure_dependencies.py	32 python ensure_dependencies.py

29 py.test \	33 py.test \
Sebastian Noack 2016/05/25 07:51:36 I think we should also run flake8, probably with a I think we should also run flake8, probably with a quite long ignore list. But at least the whitespaces should comply now, and we should make sure that we don't regress there. Vasily Kuznetsov 2016/05/25 15:17:40 Done. Not sure if this is very meaningful at this Show quoted text On 2016/05/25 07:51:36, Sebastian Noack wrote: > I think we should also run flake8, probably with a quite long ignore list. But > at least the whitespaces should comply now, and we should make sure that we > don't regress there. Done. Not sure if this is very meaningful at this point given the length of the ignore list but at least we can sort of measure progress now. We should probably start by removing the less common errors and the more "bad" errors.
30 --cov-config tox.ini --cov-report term \	34 --cov-config tox.ini --cov-report term --cov sitescripts \

31 --cov sitescripts.hg \

32 --cov sitescripts.notifications \

33 --cov sitescripts.stats \

34 sitescripts/hg/test \	35 sitescripts/hg/test \

35 sitescripts/notifications/test \	36 sitescripts/notifications/test \

36 sitescripts/stats/test	37 sitescripts/stats/test

37 rm .sitescripts.test	38 flake8 --ignore=E129,E501,E704,E711,E712,E713,E714,E731,F401,F841,F821 \

	39 sitescripts multiplexer.py multiplexer.fcgi

LEFT	RIGHT