Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: subscriptionLink.postload.js

Issue 29342971: Fixes 4065 - Subscription links on Chrome 30 (Closed)
Patch Set: Created May 24, 2016, 11:48 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: subscriptionLink.postload.js
diff --git a/subscriptionLink.postload.js b/subscriptionLink.postload.js
index 7212d635eae05f1a2c6746a03c50209da7b79310..fba7c9123088ac9d73f247fcba23a77f3d4fce11 100644
--- a/subscriptionLink.postload.js
+++ b/subscriptionLink.postload.js
@@ -55,8 +55,9 @@ if ("ext" in window && document instanceof HTMLDocument)
event.preventDefault();
event.stopPropagation();
- // Decode URL parameters
- var params = link.search.substr(1).split("&");
+ // Decode URL parameters (Note: Old versions of Chrome (30) don't populate
+ // link.search here so we have to grab the search part of the URL manually.)
+ var params = link.href.substr(link.href.indexOf("?") + 1).split("&");
var title = null;
var url = null;
for (var i = 0; i < params.length; i++)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld