Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1063)

Issue 29342994: Issue 2490 - Investigate another way to disable the crash reporter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by diegocarloslima
Modified:
3 years ago
Reviewers:
Felix Dahlke, anton
CC:
René Jeschke
Visibility:
Public.

Description

Issue 2490 - Investigate another way to disable the crash reporter

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing comments #

Total comments: 2

Patch Set 3 : Force disable crashreporter without removing upstream code #

Total comments: 2

Patch Set 4 : Adding empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M configure.in View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14
diegocarloslima
3 years, 5 months ago (2016-05-24 14:40:42 UTC) #1
diegocarloslima
3 years, 5 months ago (2016-05-24 14:44:38 UTC) #2
anton
https://codereview.adblockplus.org/29342994/diff/29342995/configure.in File configure.in (right): https://codereview.adblockplus.org/29342994/diff/29342995/configure.in#newcode6043 configure.in:6043: # case $target in should not we remove the ...
3 years, 2 months ago (2016-09-12 11:26:57 UTC) #3
diegocarloslima
https://codereview.adblockplus.org/29342994/diff/29342995/configure.in File configure.in (right): https://codereview.adblockplus.org/29342994/diff/29342995/configure.in#newcode6043 configure.in:6043: # case $target in On 2016/09/12 11:26:57, anton wrote: ...
3 years, 2 months ago (2016-09-14 23:31:24 UTC) #4
anton
On 2016/09/14 23:31:24, diegocarloslima wrote: > https://codereview.adblockplus.org/29342994/diff/29342995/configure.in > File configure.in (right): > > https://codereview.adblockplus.org/29342994/diff/29342995/configure.in#newcode6043 > ...
3 years, 1 month ago (2016-09-30 06:27:09 UTC) #5
diegocarloslima
On 2016/09/30 06:27:09, anton wrote: > On 2016/09/14 23:31:24, diegocarloslima wrote: > > https://codereview.adblockplus.org/29342994/diff/29342995/configure.in > ...
3 years ago (2016-10-20 10:06:41 UTC) #6
anton
On 2016/10/20 10:06:41, diegocarloslima wrote: > On 2016/09/30 06:27:09, anton wrote: > > On 2016/09/14 ...
3 years ago (2016-10-20 10:53:32 UTC) #7
Felix Dahlke
https://codereview.adblockplus.org/29342994/diff/29358371/configure.in File configure.in (right): https://codereview.adblockplus.org/29342994/diff/29358371/configure.in#newcode6045 configure.in:6045: MOZ_CRASHREPORTER= Could we also empty this without removing all ...
3 years ago (2016-10-20 13:27:03 UTC) #8
Felix Dahlke
On 2016/10/20 13:27:03, Felix Dahlke wrote: > https://codereview.adblockplus.org/29342994/diff/29358371/configure.in > File configure.in (right): > > https://codereview.adblockplus.org/29342994/diff/29358371/configure.in#newcode6045 ...
3 years ago (2016-10-20 13:31:52 UTC) #9
Felix Dahlke
On 2016/10/20 13:31:52, Felix Dahlke wrote: > On 2016/10/20 13:27:03, Felix Dahlke wrote: > > ...
3 years ago (2016-10-21 11:26:55 UTC) #10
diegocarloslima
On 2016/10/21 11:26:55, Felix Dahlke wrote: > On 2016/10/20 13:31:52, Felix Dahlke wrote: > > ...
3 years ago (2016-10-25 13:40:33 UTC) #11
diegocarloslima
https://codereview.adblockplus.org/29342994/diff/29358371/configure.in File configure.in (right): https://codereview.adblockplus.org/29342994/diff/29358371/configure.in#newcode6045 configure.in:6045: MOZ_CRASHREPORTER= On 2016/10/20 13:27:03, Felix Dahlke wrote: > Could ...
3 years ago (2016-10-25 13:41:42 UTC) #12
Felix Dahlke
LGTM, up to you whether you want to address my nit. https://codereview.adblockplus.org/29342994/diff/29359876/configure.in File configure.in (right): ...
3 years ago (2016-10-25 15:15:03 UTC) #13
diegocarloslima
3 years ago (2016-10-25 15:17:12 UTC) #14
https://codereview.adblockplus.org/29342994/diff/29359876/configure.in
File configure.in (right):

https://codereview.adblockplus.org/29342994/diff/29359876/configure.in#newcod...
configure.in:6076: # Force disable crashreporter
On 2016/10/25 15:15:03, Felix Dahlke wrote:
> Ultra nit: I guess I'd add an empty line on top of this in the general spirit
of
> the file, but wouldn't insist :)

Ok, I'll add that
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5