Issue 3675 - Add some tests for ContentBlockerList

lib/abp2blocklist.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 231 matching lines @@
   {
     rules.push({
       trigger: {
         "url-filter": ".*",
         "if-domain": addDomainPrefix([parsed.hostname])
       },
       action: {type: "ignore-previous-rules"}
     });
     // If the filter contains other supported options we'll need to generate
     // further rules for it, but if not we can simply return now.
-    if (!(filter.contentType | whitelistableRequestTypes))
+    if (!(filter.contentType & whitelistableRequestTypes))

[kzar, 2016/05/25 16:20:54]

Fixed this bug in the process of writing the tests :)

[Sebastian Noack, 2016/05/25 17:16:33]

Awesome, but how will that fix ever be tested, or mentioned in the release
announcements if there is no issue to track it? ;)

[kzar, 2016/05/25 18:31:54]

Good point, created this issue https://issues.adblockplus.org/ticket/4072

       return;
   }
 
   let trigger = {"url-filter": parsed.regexp};
 
   // Limit rules to HTTP(S) URLs
   if (!/^(\^|http)/i.test(trigger["url-filter"]))
     trigger["url-filter"] = "^https?://.*" + trigger["url-filter"];
 
   // For rules containing only a hostname we know that we're matching against
@@ skipping 198 matching lines @@
 
   for (let filter of this.elemhideExceptions)
     convertFilterAddRules(rules, filter, "ignore-previous-rules", false);
   for (let filter of this.requestFilters)
     convertFilterAddRules(rules, filter, "block", true);
   for (let filter of this.requestExceptions)
     convertFilterAddRules(rules, filter, "ignore-previous-rules", true);
 
   return rules.filter(rule => !hasNonASCI(rule));
 };