Noissue - Got rid of E129, E704, E712, E731 and F821 errors

sitescripts/notifications/parser.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 78 matching lines @@
             else:
                 current["targets"] = [target]
         elif key == "sample" and is_variant:
             current["sample"] = float(value)
         elif key in ["start", "end"]:
             current[key] = datetime.datetime.strptime(value, "%Y-%m-%dT%H:%M")
         else:
             raise Exception("Unknown parameter '%s' in file '%s'" % (key, name))
 
     for text_key in ("title", "message"):
-        def has_default_locale(variant): return "en-US" in variant[text_key]
-        if (not has_default_locale(notification) and
-            not all(map(has_default_locale, notification.get("variants", [])))):
-            raise Exception("No %s for en-US (default language) in file '%s'" %
-                            (text_key, name))
+        def has_default_locale(variant):
+            return "en-US" in variant[text_key]
+        if not has_default_locale(notification):
+            variants = notification.get("variants", [])
+            if not all(map(has_default_locale, variants)):
+                raise Exception("No %s for en-US (default language) "
+                                "in file '%s'" % (text_key, name))
     return notification
 
 
 def load_notifications():
     repo = get_config().get("notifications", "repository")
     command = ["hg", "-R", repo, "archive", "-r", "default", "-t", "tar",
                "-p", ".", "-X", os.path.join(repo, ".hg_archival.txt"), "-"]
     data = subprocess.check_output(command)
 
     notifications = []
@@ skipping 10 matching lines @@
                     if not "inactive" in notification:
                         current_time = datetime.datetime.now()
                         start = notification.pop("start", current_time)
                         end = notification.pop("end", current_time)
                         if not start <= current_time <= end:
                             notification["inactive"] = True
                     notifications.append(notification)
                 except:
                     traceback.print_exc()
     return notifications