Issue 4031 - Implement tests for libadblockplus-android

libadblockplus-android-tests/build.xml

 <?xml version="1.0" encoding="UTF-8"?>
-<project name="Adblock Plus Library" default="help">
+<project name="Adblock Plus Library Tests" default="help">
 
     <!-- The local.properties file is created and updated by the 'android' tool.
          It contains the path to the SDK. It should *NOT* be checked into
          Version Control Systems. -->
     <property file="local.properties" />
 
     <!-- The ant.properties file can be created by you. It is only edited by the
          'android' tool to add properties to it.
          This is the place to change some Ant specific build properties.
          Here are some properties you may want to change/update:
 
          source.dir
              The name of the source directory. Default is 'src'.
          out.dir
              The name of the output directory. Default is 'bin'.
 
          For other overridable properties, look at the beginning of the rules
          files in the SDK, at tools/ant/build.xml
 
          Properties related to the SDK location or the project target should
          be updated using the 'android' tool with the 'update' action.
 
          This file is an integral part of the build system for your
          application and should be checked into Version Control Systems.
 
          -->
     <property file="ant.properties" />
 
+    <!-- if sdk.dir was not set from one of the property file, then

[Felix Dahlke, 2016/09/12 13:52:13]

Nit: "one of the property files"?

[Felix Dahlke, 2016/09/13 08:30:14]

What about this comment?

[Felix Dahlke, 2016/09/13 10:51:44]

You don't seem to have noticed this comment, hm?

[Felix Dahlke, 2016/09/15 08:54:38]

You still don't seem to have noticed this comment.

Can you make sure to address all comments one way or another? If you tackled
them you can just hit "Done", then the reviewer knows you've changed something.
If you don't agree with a comment, please respond.

[anton, 2016/09/15 10:09:33]

Sorry for not replying to this.

There are few "*.properties" files where local variable can be set:
ant.properties and local.properties (see above).
sdk.dir can be declared in any of them, usually in local.properties. Everything
looks good for me here.

[Felix Dahlke, 2016/09/15 10:31:26]

I know, I was just complaining about the grammar: "one of the property file" ->
"one of the property files".

+         get it from the ANDROID_HOME env var.
+         This must be done before we load project.properties since
+         the proguard config can use sdk.dir -->
+    <property environment="env" />
+    <condition property="sdk.dir" value="${env.ANDROID_HOME}">
+        <isset property="env.ANDROID_HOME" />
+    </condition>
+
     <!-- The project.properties file is created and updated by the 'android'
          tool, as well as ADT.
 
          This contains project specific properties such as project target, and library
          dependencies. Lower level build properties are stored in ant.properties
          (or in .classpath for Eclipse projects).
 
          This file is an integral part of the build system for your
          application and should be checked into Version Control Systems. -->
     <loadproperties srcFile="project.properties" />
 
-    <target name="jni" description="Compiles and builds NDK libraries.">
-        <exec executable="${ndk.dir}/ndk-build" failonerror="true" />
-    </target>
+    <!-- quick check on sdk.dir -->
+    <fail
+            message="sdk.dir is missing. Make sure to generate local.properties using 'android update project' or to inject it through the ANDROID_HOME environment variable."
+            unless="sdk.dir"
+    />
 
-    <target name="-pre-build" depends="jni">
-    </target>
-
-    <target name="-pre-clean">
-        <delete dir="${native.libs.absolute.dir}/armeabi" verbose="${verbose}" />
-        <delete dir="${native.libs.absolute.dir}/armeabi-v7a" verbose="${verbose}" />
-        <delete dir="${native.libs.absolute.dir}/x86" verbose="${verbose}" />
-        <delete dir="obj/" verbose="${verbose}" />
-    </target>
+    <!--
+        Import per project custom build rules if present at the root of the project.
+        This is the place to put custom intermediary targets such as:
+            -pre-build
+            -pre-compile
+            -post-compile (This is typically used for code obfuscation.
+                           Compiled code location: ${out.classes.absolute.dir}
+                           If this is not done in place, override ${out.dex.input.absolute.dir})
+            -post-package
+            -post-build
+            -pre-clean
+    -->
+    <import file="custom_rules.xml" optional="true" />
 
     <!-- Import the actual build file.
 
          To customize existing targets, there are two options:
          - Customize only one target:
              - copy/paste the target into this file, *before* the
                <import> task.
              - customize it to your needs.
          - Customize the whole content of build.xml
              - copy/paste the content of the rules files (minus the top node)
                into this file, replacing the <import> task.
              - customize to your needs.
 
          ***********************
          ****** IMPORTANT ******
          ***********************
          In all cases you must update the value of version-tag below to read 'custom' instead of an integer,
          in order to avoid having your file be overridden by tools such as "android update project"
     -->
-    <!-- version-tag: custom -->
+    <!-- version-tag: 1 -->
     <import file="${sdk.dir}/tools/ant/build.xml" />
 
 </project>