Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: libadblockplus-android-tests/libs/junit-4.11.jar
Issue
29344967
:
Issue 4031 - Implement tests for libadblockplus-android (Closed)
Patch Set: fixed in README.md
Created Sept. 13, 2016, 10:43 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Updated tests, also moved to libadblockplus-android repo
Patch Set 3: Applied Eyeo's codestyle
Patch Set 4: With fixed version
Patch Set 5: fixed "B" to "b" (Fhd)
Patch Set 6: fixed in README.md
Patch Set 7: fixing spaces
Patch Set 8: fix typo ".. file[s]"
Right:
Patch Set 1: None
Patch Set 2: Updated tests, also moved to libadblockplus-android repo
Patch Set 3: Applied Eyeo's codestyle
Patch Set 4: With fixed version
Patch Set 5: fixed "B" to "b" (Fhd)
Patch Set 6: fixed in README.md
Patch Set 7: fixing spaces
Patch Set 8: fix typo ".. file[s]"
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.hgignore
README.md
libadblockplus-android-tests/AndroidManifest.xml
libadblockplus-android-tests/ant.properties
libadblockplus-android-tests/build.xml
libadblockplus-android-tests/libs/android-testing-support.jar
libadblockplus-android-tests/libs/junit-4.11.jar
libadblockplus-android-tests/proguard-project.txt
libadblockplus-android-tests/project.properties
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyLogSystem.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockLogSystem.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockUpdateAvailableCallback.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockWebRequest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/NoOpUpdaterCallback.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingLogSystem.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingWebRequest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/ConsoleJsObjectTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineGenericTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineUpdaterTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/GlobalJsObjectTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/JsEngineTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/JsTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/NotificationTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdateCheckTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java
View unified diff
|
Download patch
« no previous file with comments
|
« libadblockplus-android-tests/libs/android-testing-support.jar
('k') |
libadblockplus-android-tests/proguard-project.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« no previous file with comments
|
« libadblockplus-android-tests/libs/android-testing-support.jar
('k') |
libadblockplus-android-tests/proguard-project.txt »
('j') |
no next file with comments »
Edit Message
Issue 29344967: Issue 4031 - Implement tests for libadblockplus-android (Closed)
Created May 27, 2016, 1:38 p.m. by anton
Modified Sept. 16, 2016, 7:11 a.m.
Reviewers: diegocarloslima, Felix Dahlke
Base URL:
Comments: 21
This is Rietveld