README.md - Issue 29344967: Issue 4031 - Implement tests for libadblockplus-android

Delta Between Two Patch Sets: README.md

Issue 29344967: Issue 4031 - Implement tests for libadblockplus-android (Closed)

Left Patch Set: With fixed version Created Sept. 8, 2016, 1:53 p.m.

Right Patch Set: fix typo ".. file[s]" Created Sept. 15, 2016, 10:44 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 Adblock Plus Library for Android	1 Adblock Plus Library for Android

2 ========================	2 ========================

3	3

4 An Android library project that runs a proxy to block ads.	4 An Android library project that runs a proxy to block ads.

5	5

6 Updating the dependencies	6 Updating the dependencies

7 -------------------------	7 -------------------------

8	8

9 Adblock Plus Library for Android has dependencies that aren't in this repository .	9 Adblock Plus Library for Android has dependencies that aren't in this repository .

10 To update those, call:	10 To update those, call:

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 ## Library tests	55 ## Library tests

56	56

57 ### Requirements	57 ### Requirements

58	58

59 Make sure _Library_ requirements are present.	59 Make sure _Library_ requirements are present.

60	60

61 ### Building	61 ### Building

62	62

63 Set ANDROID_HOME environment variable to your Android SDK directory.	63 Set ANDROID_HOME environment variable to your Android SDK directory.

64	64

65 In the 'libadblockplus-android-tests' run:	65 In the 'libadblockplus-android-tests' directory run:
Felix Dahlke 2016/09/12 13:52:12 Nit: "In the 'libadblockplus-android-tests' direct Nit: "In the 'libadblockplus-android-tests' directory"? anton 2016/09/13 05:49:08 Yes, it's "Library tests" README section and it's Show quoted text On 2016/09/12 13:52:12, Felix Dahlke wrote: > Nit: "In the 'libadblockplus-android-tests' directory"? Yes, it's "Library tests" README section and it's about the tests. We're having "libadblockplus-android" directory with jni-glue files and "libadblockplus-android-tests" with the tests. We need to run in "libadblockplus-android-tests" to build both tests and dependencies (jni glue) so it's not mistyping Felix Dahlke 2016/09/13 08:30:13 Just to clarify, what I meant here is that the sen Show quoted text On 2016/09/13 05:49:08, anton wrote: > On 2016/09/12 13:52:12, Felix Dahlke wrote: > > Nit: "In the 'libadblockplus-android-tests' directory"? > > Yes, it's "Library tests" README section and it's about the tests. We're having > "libadblockplus-android" directory with jni-glue files and > "libadblockplus-android-tests" with the tests. We need to run in > "libadblockplus-android-tests" to build both tests and dependencies (jni glue) > so it's not mistyping Just to clarify, what I meant here is that the sentence sounds weird this way: "In the $directory_name run", so I suggested to write "In the $directory_name directory run". You also say "In the 'libadblockplus-android-tests' directory run" below, so this sentence here seemed like it's just missing a "directory". anton 2016/09/13 10:44:37 Acknowledged. Show quoted text On 2016/09/13 08:30:13, Felix Dahlke wrote: > On 2016/09/13 05:49:08, anton wrote: > > On 2016/09/12 13:52:12, Felix Dahlke wrote: > > > Nit: "In the 'libadblockplus-android-tests' directory"? > > > > Yes, it's "Library tests" README section and it's about the tests. We're > having > > "libadblockplus-android" directory with jni-glue files and > > "libadblockplus-android-tests" with the tests. We need to run in > > "libadblockplus-android-tests" to build both tests and dependencies (jni glue) > > so it's not mistyping > > Just to clarify, what I meant here is that the sentence sounds weird this way: > "In the $directory_name run", so I suggested to write "In the $directory_name > directory run". You also say "In the 'libadblockplus-android-tests' directory > run" below, so this sentence here seemed like it's just missing a "directory". Acknowledged.
66	66

67 ant instrument	67 ant instrument

68	68

69 ### Testing	69 ### Testing

70	70

71 1. Connect an Android device or start the Android Emulator.	71 1. Connect an Android device or start the Android Emulator.

72 2. In the 'libadblockplus-android-tests' directory run:	72 2. In the 'libadblockplus-android-tests' directory run:

73	73

74 ant instrument install test	74 ant instrument install test

75	75

76 to build instrumentation tests app and perform testing or run:	76 to build instrumentation tests app and perform testing or run:

77	77

78 ant test	78 ant test

79	79

80 to run installed instrumentation tests app	80 to run installed instrumentation tests app.
Felix Dahlke 2016/09/12 13:52:12 Nit: Missing period? :D Nit: Missing period? :D anton 2016/09/13 05:49:08 did not catch that. it can be called "instrumentat Show quoted text On 2016/09/12 13:52:12, Felix Dahlke wrote: > Nit: Missing period? :D did not catch that. it can be called "instrumentation tests app". it's an application that has instrumented code and actually the whole app is tests Felix Dahlke 2016/09/13 08:30:13 I know, I'm just saying that there appears to be a Show quoted text On 2016/09/13 05:49:08, anton wrote: > On 2016/09/12 13:52:12, Felix Dahlke wrote: > > Nit: Missing period? :D > > did not catch that. it can be called "instrumentation tests app". it's an > application that has instrumented code and actually the whole app is tests I know, I'm just saying that there appears to be a period (".") missing at the end of the sentence.
LEFT	RIGHT