Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29345120: Noissue - Got rid of non-default script encodings (Closed)

Created:
May 28, 2016, 11:32 a.m. by Sebastian Noack
Modified:
May 30, 2016, 12:36 p.m.
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Noissue - Got rid of non-default script encodings

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -113 lines) Patch
M multiplexer.fcgi View 1 chunk +0 lines, -1 line 0 comments Download
M multiplexer.py View 1 chunk +0 lines, -1 line 0 comments Download
M sitescripts/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/content_blocker_lists/bin/generate_lists.py View 1 chunk +0 lines, -1 line 0 comments Download
M sitescripts/crashes/web/submitCrash.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/crawler/bin/import_sites.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/extensions/bin/updateRecommendations.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/extensions/bin/updateUpdateManifests.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/extensions/web/adblockbrowserUpdates.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/extensions/web/downloads.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/formmail/web/formmail.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/management/bin/generateHgAuth.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/management/bin/generateNotifications.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/management/bin/installChanges.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/management/bin/start_services.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/notifications/parser.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/notifications/test/notification.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/notifications/test/parser.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/notifications/web/notification.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/bin/mailDigests.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/bin/parseNewReports.py View 2 chunks +2 lines, -4 lines 0 comments Download
M sitescripts/reports/bin/processReports.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/bin/removeOldReports.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/bin/removeOldUsers.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/bin/updateDigests.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/bin/updateSubscriptionList.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/utils.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/web/showDigest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/web/showUser.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/web/submitReport.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/reports/web/updateReport.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/send_installation_link/web/send_installation_link.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/stats/bin/logprocessor.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/stats/bin/pagegenerator.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/stats/common.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/stats/test/common.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/stats/test/logprocessor.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/submit_email/web/submit_email.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/bin/generateReport.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/bin/processTemplate.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/bin/updateMalwareDomainsList.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/bin/updateStatusPage.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/bin/updateSubscriptionDownloads.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/bin/updateSubscriptionDownloadsCVS.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/combineSubscriptions.py View 1 chunk +0 lines, -1 line 0 comments Download
M sitescripts/subscriptions/knownIssuesParser.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/subscriptionParser.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/web/fallback.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/templateFilters.py View 2 chunks +1 line, -3 lines 0 comments Download
M sitescripts/testpages/web/sitekey_frame.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/urlfixer/bin/forceDomains.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/urlfixer/bin/topDomains.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/urlfixer/web/submitData.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/utils.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/web.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
For reference, I didn't retest any of these scripts, but made sure that the bytecode ...
May 28, 2016, 11:33 a.m. (2016-05-28 11:33:10 UTC) #1
Vasily Kuznetsov
LGTM
May 30, 2016, 8:48 a.m. (2016-05-30 08:48:49 UTC) #2
Vasily Kuznetsov
Just a small nit, which I hope you noticed already: there's a typo in the ...
May 30, 2016, 12:18 p.m. (2016-05-30 12:18:45 UTC) #3
Sebastian Noack
May 30, 2016, 12:22 p.m. (2016-05-30 12:22:08 UTC) #4 
On 2016/05/30 12:18:45, Vasily Kuznetsov wrote:
> Just a small nit, which I hope you noticed already: there's a typo in the
title
> of this review, hope it doesn't make it into commit message.

I just fixed it. But too late for the respective commit in buildtools and cms
which already got pushed.

Powered by Google App Engine
This is Rietveld