Issue 4084 - Do not use @@bidi_dir directly in adblockplusui

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 163 matching lines @@
           });
         }
         else if (message.what == "doclink")
           callback(Utils.getDocLink(message.link));
         else if (message.what == "localeInfo")
         {
           var bidiDir;
           if ("chromeRegistry" in Utils)
             bidiDir = Utils.chromeRegistry.isLocaleRTL("adblockplus") ? "rtl" : "ltr";
           else
-            bidiDir = ext.i18n.getMessage("@@bidi_dir");
+            bidiDir = Utils.readingDirection;

[Sebastian Noack, 2016/05/30 14:16:57]

I guess we should move the logic for @@bidi_dir and @@ui_locale from
ext/common.js here. If those aren't supported by ext.chrome.getMessage() on all
platforms, the mock implementation shouldn't support it either, otherwise
somebody might start using it without noticing that it won't work on Edge.

 
           callback({locale: Utils.appLocale, bidiDir: bidiDir});
         }
         else if (message.what == "features")
         {
           callback({
             devToolsPanel: info.platform == "chromium",
             safariContentBlocker: "safari" in global
                 && "extension" in global.safari
                 && "setContentBlocker" in global.safari.extension
@@ skipping 207 matching lines @@
         for (var i = 0; i < subscriptions.length; i++)
         {
           var subscription = subscriptions[i];
           if (subscription instanceof DownloadableSubscription)
             Synchronizer.execute(subscription, true);
         }
         break;
     }
   });
 })(this);