Issue 4084 - Do not use @@bidi_dir directly in adblockplusui

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 73 matching lines @@
   };
 
   modules.utils = {
     Utils: {
       getDocLink(link)
       {
         return "https://adblockplus.org/redirect?link=" + encodeURIComponent(link);
       },
       get appLocale()
       {
-        return parent.ext.i18n.getMessage("@@ui_locale").replace(/_/g, "-");
+        return parent.ext.i18n.locale.replace(/_/g, "-");
+      }
+      get readingDirection()
+      {
+        reuturn bidiDir = /^(ar|fa|he|ug|ur)(-|$)/.test(this.appLocale) ?

[Thomas Greiner, 2017/08/29 08:51:17]

Typo: Replace "reuturn" with "return"

[Thomas Greiner, 2017/08/29 08:51:17]

Suggestion: We're not using the values in the capture groups here and we may not
care about which character comes after the prefix so my suggestion would be
this: /^(?:ar|fa|he|ug|ur)\b/

[Oleksandr, 2017/08/29 11:26:29]

Rebase artifact. There was more than just this too. Thanks!

+          "rtl" : "ltr";
       }
     }
   };
 
   modules.prefs = {Prefs: new EventEmitter()};
   let prefs = {
     notifications_ignoredcategories: (params.showNotificationUI) ? ["*"] : [],
     notifications_showui: params.showNotificationUI,
     shouldShowBlockElementMenu: true,
     show_devtools_panel: true,
@@ skipping 458 matching lines @@
       },
       filter: {
         text: "||example.com/some-annoying-popup$popup",
         whitelisted: false,
         userDefined: true,
         subscription: null
       }
     });
   });
 }());