Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: background.js

Issue 29345232: Issue 4084 - Do not use @@bidi_dir directly in adblockplusui (Closed)
Patch Set: Rebase Created Aug. 28, 2017, 4:58 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ext/common.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 }; 84 };
85 85
86 modules.utils = { 86 modules.utils = {
87 Utils: { 87 Utils: {
88 getDocLink(link) 88 getDocLink(link)
89 { 89 {
90 return "https://adblockplus.org/redirect?link=" + encodeURIComponent(lin k); 90 return "https://adblockplus.org/redirect?link=" + encodeURIComponent(lin k);
91 }, 91 },
92 get appLocale() 92 get appLocale()
93 { 93 {
94 return parent.ext.i18n.getMessage("@@ui_locale").replace(/_/g, "-"); 94 return parent.ext.i18n.locale.replace(/_/g, "-");
95 }
96 get readingDirection()
97 {
98 reuturn bidiDir = /^(ar|fa|he|ug|ur)(-|$)/.test(this.appLocale) ?
Thomas Greiner 2017/08/29 08:51:17 Typo: Replace "reuturn" with "return"
Thomas Greiner 2017/08/29 08:51:17 Suggestion: We're not using the values in the capt
Oleksandr 2017/08/29 11:26:29 Rebase artifact. There was more than just this too
99 "rtl" : "ltr";
95 } 100 }
96 } 101 }
97 }; 102 };
98 103
99 modules.prefs = {Prefs: new EventEmitter()}; 104 modules.prefs = {Prefs: new EventEmitter()};
100 let prefs = { 105 let prefs = {
101 notifications_ignoredcategories: (params.showNotificationUI) ? ["*"] : [], 106 notifications_ignoredcategories: (params.showNotificationUI) ? ["*"] : [],
102 notifications_showui: params.showNotificationUI, 107 notifications_showui: params.showNotificationUI,
103 shouldShowBlockElementMenu: true, 108 shouldShowBlockElementMenu: true,
104 show_devtools_panel: true, 109 show_devtools_panel: true,
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 }, 568 },
564 filter: { 569 filter: {
565 text: "||example.com/some-annoying-popup$popup", 570 text: "||example.com/some-annoying-popup$popup",
566 whitelisted: false, 571 whitelisted: false,
567 userDefined: true, 572 userDefined: true,
568 subscription: null 573 subscription: null
569 } 574 }
570 }); 575 });
571 }); 576 });
572 }()); 577 }());
OLDNEW
« no previous file with comments | « no previous file | ext/common.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld