Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: messageResponder.js

Issue 29345232: Issue 4084 - Do not use @@bidi_dir directly in adblockplusui (Closed)
Patch Set: Rebase Created Aug. 28, 2017, 4:58 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« background.js ('K') | « ext/common.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 167
168 if (message.what == "localeInfo") 168 if (message.what == "localeInfo")
169 { 169 {
170 let bidiDir; 170 let bidiDir;
171 if ("chromeRegistry" in Utils) 171 if ("chromeRegistry" in Utils)
172 { 172 {
173 let isRtl = Utils.chromeRegistry.isLocaleRTL("adblockplus"); 173 let isRtl = Utils.chromeRegistry.isLocaleRTL("adblockplus");
174 bidiDir = isRtl ? "rtl" : "ltr"; 174 bidiDir = isRtl ? "rtl" : "ltr";
175 } 175 }
176 else 176 else
177 bidiDir = ext.i18n.getMessage("@@bidi_dir"); 177 bidiDir = Utils.readingDirection;
178 178
179 return {locale: Utils.appLocale, bidiDir}; 179 return {locale: Utils.appLocale, bidiDir};
180 } 180 }
181 181
182 if (message.what == "features") 182 if (message.what == "features")
183 { 183 {
184 return { 184 return {
185 devToolsPanel: info.platform == "chromium" 185 devToolsPanel: info.platform == "chromium"
186 }; 186 };
187 } 187 }
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 if (message.url) 424 if (message.url)
425 subscriptions = [Subscription.fromURL(message.url)]; 425 subscriptions = [Subscription.fromURL(message.url)];
426 426
427 for (let subscription of subscriptions) 427 for (let subscription of subscriptions)
428 { 428 {
429 if (subscription instanceof DownloadableSubscription) 429 if (subscription instanceof DownloadableSubscription)
430 Synchronizer.execute(subscription, true); 430 Synchronizer.execute(subscription, true);
431 } 431 }
432 }); 432 });
433 })(this); 433 })(this);
OLDNEW
« background.js ('K') | « ext/common.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld