Issue 4084 - Do not use @@bidi_dir directly in adblockplusui

ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 81 matching lines @@
       candidates.push(language + "-" + region);
 
     candidates.push(language);
 
     if (candidates.indexOf(defaultLocale) == -1)
       candidates.push(defaultLocale);
 
     return candidates;
   };
 
-  let initCatalog = function(uiLocale)
-  {
-    let bidiDir = /^(ar|fa|he|ug|ur)(-|$)/.test(uiLocale) ? "rtl" : "ltr";
-    let catalog = Object.create(null);
-
-    catalog["@@ui_locale"] = [uiLocale.replace(/-/g, "_"), []];
-    catalog["@@bidi_dir"] = [bidiDir, []];
-
-    return catalog;
-  };
-
   let selectedLocale = window.navigator.language;
   let match = /[?&]locale=([\w-]+)/.exec(window.location.search);
   if (match)
     selectedLocale = match[1];
 
   let locales = getLocaleCandidates(selectedLocale);
-  let catalog = initCatalog(locales[0]);
+  let catalog = Object.create(null);
   let catalogFile = window.location.pathname.replace(/.*\//, "")
     .replace(/\..*/, "") + ".json";
 
   let replacePlaceholder = function(text, placeholder, content)
   {
     return text.split("$" + placeholder + "$").join(content || "");
   };
 
   let parseMessage = function(rawMessage)
   {
@@ skipping 33 matching lines @@
 
     let rawCatalog = JSON.parse(xhr.responseText);
     for (let msgId in rawCatalog)
     {
       if (!(msgId in catalog))
         catalog[msgId] = parseMessage(rawCatalog[msgId]);
     }
   };
 
   window.ext.i18n = {
+    locale: locales[0],
     getMessage(msgId, substitutions)
     {
       while (true)
       {
         let message = catalog[msgId];
         if (message)
         {
           let text = message[0];
           let placeholders = message[1];
 
           if (!(substitutions instanceof Array))
             substitutions = [substitutions];
 
           for (let i = 0; i < placeholders.length; i++)
             text = replacePlaceholder(text, placeholders[i], substitutions[i]);
 
           return text;
         }
 
         if (locales.length == 0)
           return "";
 
         let locale = locales.shift();
         readCatalog(locale, "common.json");
         readCatalog(locale, catalogFile);
       }
     }
   };
 }());