background.js - Issue 29345232: Issue 4084 - Do not use @@bidi_dir directly in adblockplusui

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 29345232: Issue 4084 - Do not use @@bidi_dir directly in adblockplusui (Closed)

Patch Set: Do not pretent to support getMessage for @@ui_locale and @@bidi_dir Created May 30, 2016, 4:59 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

diff --git a/background.js b/background.js

index d3cab934fadb6a0dd247ca4faf8898128deea9de..51a52d143e389af2596673c8202ec10b9f24fc13 100644

--- a/background.js

+++ b/background.js

@@ -90,8 +90,12 @@

get appLocale()

{

- return parent.ext.i18n.getMessage("@@ui_locale").replace(/_/g, "-");

- }

+ return parent.ext.i18n.locale.replace(/_/g, "-");

+ },

+ get readingDirection()

+ {

+ return bidiDir = /^(ar|fa|he|ug|ur)(-|$)/.test(this.appLocale) ? "rtl" : "ltr";

+ }

}

};

« no previous file with comments | « no previous file | ext/common.js » ('j') | no next file with comments »