Issue 29345279: Noissue - Adapt quotes for compliance with our coding style in buildtools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29345279: Noissue - Adapt quotes for compliance with our coding style in buildtools (Closed)

Created:
May 29, 2016, 1:27 p.m. by Sebastian Noack

Modified:
May 30, 2016, 12:17 p.m.

Reviewers:
Vasily Kuznetsov

Visibility:
Public.

Description

Noissue - Adapt quotes for compliance with our coding style in buildtools

Patch Set 1 #

Created: May 29, 2016, 1:27 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+182 lines, -185 lines)			Patch
M	build.py	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	chainedconfigparser.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ensure_dependencies.py	View	14 chunks	+88 lines, -88 lines	0 comments	Download
M	localeTools.py	View	4 chunks	+61 lines, -61 lines	0 comments	Download
M	packager.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	packagerChrome.py	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	packagerGecko.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	publicSuffixListUpdater.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	releaseAutomation.py	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	tox.ini	View	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

All changes except for tox.ini have been performed automatically by this script: https://gist.github.com/snoack/ca864fbab537782e574508e0368de033 I verified ...

May 29, 2016, 1:29 p.m. (2016-05-29 13:29:54 UTC) #1

LGTM

Expand All Messages | Collapse All Messages