Issue 4086 - JsValue.isNumber() crashes

libadblockplus-android/jni/JniJsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 19 matching lines @@
 
 static jboolean JNICALL JniIsNull(JNIEnv* env, jclass clazz, jlong ptr)
 {
   try
   {
     return JniGetJsValue(ptr)->IsNull() ? JNI_TRUE : JNI_FALSE;
   }
   CATCH_THROW_AND_RETURN(env, JNI_FALSE)
 }
 
+static jboolean JNICALL JniIsNumber(JNIEnv* env, jclass clazz, jlong ptr)
+{
+  try
+  {
+    return JniGetJsValue(ptr)->IsNumber() ? JNI_TRUE : JNI_FALSE;
+  }
+  CATCH_THROW_AND_RETURN(env, JNI_FALSE)
+}
+
 static jboolean JNICALL JniIsString(JNIEnv* env, jclass clazz, jlong ptr)
 {
   try
   {
     return JniGetJsValue(ptr)->IsString() ? JNI_TRUE : JNI_FALSE;
   }
   CATCH_THROW_AND_RETURN(env, JNI_FALSE)
 }
 
 static jboolean JNICALL JniIsBoolean(JNIEnv* env, jclass clazz, jlong ptr)
@@ skipping 135 matching lines @@
 //void SetProperty(const std::string& name, JsValuePtr value);
 //void SetProperty(const std::string& name, const char* val);
 //inline void SetProperty(const std::string& name, int val);
 //std::string GetClass() const;
 //JsValuePtr Call(const JsValueList& params = JsValueList(), AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const;
 
 static JNINativeMethod methods[] =
 {
   { (char*)"isUndefined", (char*)"(J)Z", (void*)JniIsUndefined },
   { (char*)"isNull", (char*)"(J)Z", (void*)JniIsNull },
+  { (char*)"isNumber", (char*)"(J)Z", (void*)JniIsNumber },
   { (char*)"isString", (char*)"(J)Z", (void*)JniIsString },
   { (char*)"isBoolean", (char*)"(J)Z", (void*)JniIsBoolean },
   { (char*)"isObject", (char*)"(J)Z", (void*)JniIsObject },
   { (char*)"isArray", (char*)"(J)Z", (void*)JniIsArray },
   { (char*)"isFunction", (char*)"(J)Z", (void*)JniIsFunction },
   { (char*)"asString", (char*)"(J)Ljava/lang/String;", (void*)JniAsString },
   { (char*)"asLong", (char*)"(J)J", (void*)JniAsLong },
   { (char*)"asBoolean", (char*)"(J)Z", (void*)JniAsBoolean },
   { (char*)"asList", (char*)"(J)Ljava/util/List;", (void*)JniAsList },
   { (char*)"getProperty", (char*)"(JLjava/lang/String;)" TYP("JsValue"), (void*)JniGetProperty },
   { (char*)"dtor", (char*)"(J)V", (void*)JniDtor }
 };
 
 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_libadblockplus_JsValue_registerNatives(JNIEnv *env, jclass clazz)
 {
   env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0]));
 }