Issue 29345369: Issue 4081 - Fix failing MockWebRequestTest test for libadblockplus-android

Issue 29345369: Issue 4081 - Fix failing MockWebRequestTest test for libadblockplus-android (Closed)

Created:
May 30, 2016, 2:56 p.m. by anton

Modified:
Sept. 16, 2016, 10:27 a.m.

Reviewers:
diegocarloslima, Felix Dahlke

CC:
René Jeschke

Visibility:
Public.

Description

Issue 4081 - Fix failing MockWebRequestTest test for libadblockplus-android #depends on https://codereview.adblockplus.org/29344967/

Patch Set 2 : with Utils' JniJavaToStdString #

Total comments: 8

Patch Set 3 : Full changes set (including initial changeset for this issue and codestyle/commitstyle fixes) #

Total comments: 2

Patch Set 4 : fixed .hgignore and spaces in c++ "for" #

Total comments: 2

Patch Set 5 : reverting changes to .hgignore #

Created: Sept. 13, 2016, 10:34 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
M	.hgignore	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	libadblockplus-android/jni/JniWebRequest.cpp	View	1 2 3	2 chunks	+21 lines, -1 line	0 comments	Download
M	libadblockplus-android/jni/Utils.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

René Jeschke

https://codereview.adblockplus.org/29345369/diff/29346750/.hgignore File .hgignore (right): https://codereview.adblockplus.org/29345369/diff/29346750/.hgignore#newcode15 .hgignore:15: .git These changes are unrelated. If you want to ...

July 12, 2016, 4:22 p.m. (2016-07-12 16:22:53 UTC) #2

anton

July 13, 2016, 6:49 a.m. (2016-07-13 06:49:52 UTC) #3

diegocarloslima

On 2016/07/13 06:49:52, anton wrote: > https://codereview.adblockplus.org/29345369/diff/29346750/.hgignore > File .hgignore (right): > > https://codereview.adblockplus.org/29345369/diff/29346750/.hgignore#newcode15 > ...

Sept. 8, 2016, 3:28 p.m. (2016-09-08 15:28:40 UTC) #4

Felix Dahlke

Looks good, just a few comments. https://codereview.adblockplus.org/29345369/diff/29347727/.hgignore File .hgignore (left): https://codereview.adblockplus.org/29345369/diff/29347727/.hgignore#oldcode15 .hgignore:15: .git Would be ...

Sept. 12, 2016, 2:21 p.m. (2016-09-12 14:21:12 UTC) #5

Felix Dahlke

LGTM, if you leave the .hgignore changes out, see below. https://codereview.adblockplus.org/29345369/diff/29352791/.hgignore File .hgignore (left): https://codereview.adblockplus.org/29345369/diff/29352791/.hgignore#oldcode16 ...

Sept. 13, 2016, 8:12 a.m. (2016-09-13 08:12:36 UTC) #6

anton

Sept. 13, 2016, 10:24 a.m. (2016-09-13 10:24:42 UTC) #7

https://codereview.adblockplus.org/29345369/diff/29352791/.hgignore
File .hgignore (left):

https://codereview.adblockplus.org/29345369/diff/29352791/.hgignore#oldcode16
.hgignore:16: .gitignore
On 2016/09/13 08:12:35, Felix Dahlke wrote:
> Alright, so it seems that patch set 2 added those lines. In patch set 3 and 4
it
> does however look as if those lines were already present, and the patch was
> removing them. Looking at the current state of the repo, the lines are indeed
> there.
> 
> Can you leave them in then? My point was that this patch shouldn't make
changes
> unrelated to the issue it is trying to solve, i.e. it shouldn't change
.hgignore
> at all. Sorry for the confusion.

Acknowledged.

Expand All Messages | Collapse All Messages