.hgignore - Issue 29345369: Issue 4081 - Fix failing MockWebRequestTest test for libadblockplus-android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .hgignore

Issue 29345369: Issue 4081 - Fix failing MockWebRequestTest test for libadblockplus-android (Closed)

Patch Set: fixed .hgignore and spaces in c++ "for" Created Sept. 13, 2016, 6:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 syntax: glob	1 syntax: glob

2	2

3 libadblockplus-android/ant.properties	3 libadblockplus-android/ant.properties

4 libadblockplus-android/local.properties	4 libadblockplus-android/local.properties

5 crowdin.yaml	5 crowdin.yaml

6 libadblockplus-android/bin	6 libadblockplus-android/bin

7 libadblockplus-android/libs/armeabi*	7 libadblockplus-android/libs/armeabi*

8 libadblockplus-android/libs/x86	8 libadblockplus-android/libs/x86

9 libadblockplus-android/obj	9 libadblockplus-android/obj

10 libadblockplus-android/gen	10 libadblockplus-android/gen

11 .idea	11 .idea

12 *.iml	12 *.iml

13 upload.py	13 upload.py

14 .DS_Store	14 .DS_Store

15 .git

16 .gitignore
Felix Dahlke 2016/09/13 08:12:35 Alright, so it seems that patch set 2 added those Alright, so it seems that patch set 2 added those lines. In patch set 3 and 4 it does however look as if those lines were already present, and the patch was removing them. Looking at the current state of the repo, the lines are indeed there. Can you leave them in then? My point was that this patch shouldn't make changes unrelated to the issue it is trying to solve, i.e. it shouldn't change .hgignore at all. Sorry for the confusion. anton 2016/09/13 10:24:42 Acknowledged. Show quoted text On 2016/09/13 08:12:35, Felix Dahlke wrote: > Alright, so it seems that patch set 2 added those lines. In patch set 3 and 4 it > does however look as if those lines were already present, and the patch was > removing them. Looking at the current state of the repo, the lines are indeed > there. > > Can you leave them in then? My point was that this patch shouldn't make changes > unrelated to the issue it is trying to solve, i.e. it shouldn't change .hgignore > at all. Sorry for the confusion. Acknowledged.
OLD	NEW

« no previous file with comments | « no previous file | libadblockplus-android/jni/JniWebRequest.cpp » ('j') | no next file with comments »