Issue 4081 - Fix failing MockWebRequestTest test for libadblockplus-android

libadblockplus-android/jni/JniWebRequest.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 65 matching lines @@
           *response, "status");
       sResponse.responseStatus = JniGetIntField(*env,
           serverResponseClass->Get(), *response, "responseStatus");
       sResponse.responseText = JniGetStringField(*env,
           serverResponseClass->Get(), *response, "response");
 
       // map headers
       jobjectArray responseHeadersArray = JniGetStringArrayField(*env,
         serverResponseClass->Get(), *response, "headers");
 
-      if (responseHeadersArray) {

[René Jeschke, 2016/07/12 16:22:53]

Please pay attention to our coding style, opening braces go on a new line.

[anton, 2016/07/13 06:49:52]

Acknowledged.

+      if (responseHeadersArray)
+      {
         int itemsCount = env->GetArrayLength(responseHeadersArray) / 2;
-        for (int i=0; i<itemsCount; i++) {
-          // key

[René Jeschke, 2016/07/12 16:22:53]

This comment is not needed, the variable name speaks for itself.

[anton, 2016/07/13 06:49:52]

Acknowledged.

+        for (int i = 0; i < itemsCount; i++)
+        {
           jstring jKey = (jstring)env->GetObjectArrayElement(responseHeadersArray, i * 2);
           std::string stdKey = JniJavaToStdString(*env, jKey);
           
-          // value

[René Jeschke, 2016/07/12 16:22:53]

See // key

[anton, 2016/07/13 06:49:52]

Acknowledged.

           jstring jValue = (jstring)env->GetObjectArrayElement(responseHeadersArray, i * 2 + 1);
           std::string stdValue = JniJavaToStdString(*env, jValue);
           
           std::pair<std::string,std::string>  keyValue(stdKey, stdValue);
           sResponse.responseHeaders.push_back(keyValue);
         }
       }
     }
   }
 
@@ skipping 17 matching lines @@
 static JNINativeMethod methods[] =
 {
   { (char*)"ctor", (char*)"(Ljava/lang/Object;)J", (void*)JniCtor },
   { (char*)"dtor", (char*)"(J)V", (void*)JniDtor }
 };
 
 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_libadblockplus_WebRequest_registerNatives(JNIEnv *env, jclass clazz)
 {
   env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0]));
 }