Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(630)

Issue 29345390: Issue 3001 - FAQ settings item should lead to the Adblock Browser FAQ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by diegocarloslima
Modified:
2 years ago
Visibility:
Public.

Description

Issue 3001 - FAQ settings item should lead to the Adblock Browser FAQ

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M mobile/android/base/preferences/GeckoPreferences.java View 1 chunk +2 lines, -8 lines 1 comment Download
M mobile/android/base/resources/xml/preferences_vendor.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
diegocarloslima
2 years, 3 months ago (2016-05-31 10:02:09 UTC) #1
René Jeschke
On 2016/05/31 10:02:09, diegocarloslima wrote: LGTM
2 years, 3 months ago (2016-06-14 15:34:07 UTC) #2
Felix Dahlke
https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base/preferences/GeckoPreferences.java File mobile/android/base/preferences/GeckoPreferences.java (right): https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base/preferences/GeckoPreferences.java#newcode915 mobile/android/base/preferences/GeckoPreferences.java:915: // See https://issues.adblockplus.org/ticket/3001 Do we actually have to remove ...
2 years, 3 months ago (2016-06-16 13:33:34 UTC) #3
Felix Dahlke
On 2016/06/16 13:33:34, Felix Dahlke wrote: > https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base/preferences/GeckoPreferences.java > File mobile/android/base/preferences/GeckoPreferences.java (right): > > https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base/preferences/GeckoPreferences.java#newcode915 ...
2 years ago (2016-09-15 08:50:20 UTC) #4
diegocarloslima
2 years ago (2016-09-15 13:05:47 UTC) #5
On 2016/09/15 08:50:20, Felix Dahlke wrote:
> On 2016/06/16 13:33:34, Felix Dahlke wrote:
> >
>
https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base...
> > File mobile/android/base/preferences/GeckoPreferences.java (right):
> > 
> >
>
https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base...
> > mobile/android/base/preferences/GeckoPreferences.java:915: // See
> > https://issues.adblockplus.org/ticket/3001
> > Do we actually have to remove this code? How I see it, this'll just attempt
> > substitution, but if we don't add any substitution tags to the source
string,
> we
> > should be able to leave this code alone. Or am I missing something?
> 
> Any update here?

Actually this issue got overridden by #3220. I'm closing it now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5